Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 1921913002: MD Settings; Lazy instantiate Clear Browsing Data dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment." Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 8d52d8fff1920e354c0fb4001d6a4dbdf0847e4e..74cb40a8e6a7fee519cc9fbcc93e352b890d4029 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -22,11 +22,14 @@
<dom-module id="settings-privacy-page">
<template>
<style include="settings-shared"></style>
+ <template is="dom-if" if="[[showClearBrowsingDataDialog_]]" restamp>
+ <settings-clear-browsing-data-dialog prefs="{{prefs}}"
+ on-iron-overlay-closed="onIronOverlayClosed_">
+ </settings-clear-browsing-data-dialog>
+ </template>
<settings-animated-pages id="pages" current-route="{{currentRoute}}"
section="privacy">
<neon-animatable id="main">
- <settings-clear-browsing-data-dialog prefs="{{prefs}}">
- </settings-clear-browsing-data-dialog>
<div class="settings-box block first">
<p class="privacy-explanation"
i18n-values=".innerHTML:improveBrowsingExperience">

Powered by Google App Engine
This is Rietveld 408576698