Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 1921913002: MD Settings; Lazy instantiate Clear Browsing Data dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment." Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index f32e85380289ccf8964eb35d0ebbbd633a9f08f8..1f152149e22362a20ece96056573da13d999afc5 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -38,6 +38,9 @@ Polymer({
type: Object,
notify: true,
},
+
+ /** @private */
+ showClearBrowsingDataDialog_: Boolean,
},
ready: function() {
@@ -62,6 +65,15 @@ Polymer({
/** @private */
onClearBrowsingDataTap_: function() {
- this.$.pages.querySelector('settings-clear-browsing-data-dialog').open();
+ this.showClearBrowsingDataDialog_ = true;
+ },
+
+ /**
+ * @param {!Event} event
+ * @private
+ */
+ onIronOverlayClosed_: function(event) {
+ if (Polymer.dom(event).rootTarget.tagName == 'SETTINGS-DIALOG')
+ this.showClearBrowsingDataDialog_ = false;
},
});
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/test/data/webui/settings/privacy_page_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698