Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921893004: [Findit] Fix Key error in build_failure handler. (Closed)

Created:
4 years, 8 months ago by chanli
Modified:
4 years, 8 months ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fix Key error in build_failure handler. BUG=606957 Committed: https://chromium.googlesource.com/infra/infra/+/739589f3ba1354fd0d50595e5059d5bceb19573f

Patch Set 1 #

Patch Set 2 : group try job result in unclassified_failures if no status. #

Total comments: 3

Patch Set 3 : Add a special status to this case and add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M appengine/findit/handlers/build_failure.py View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M appengine/findit/handlers/result_status.py View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M appengine/findit/handlers/test/build_failure_test.py View 1 2 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
chanli
PTAL.
4 years, 8 months ago (2016-04-26 21:42:20 UTC) #3
chanli
PTAL.
4 years, 8 months ago (2016-04-26 21:42:38 UTC) #5
lijeffrey
https://codereview.chromium.org/1921893004/diff/60001/appengine/findit/handlers/build_failure.py File appengine/findit/handlers/build_failure.py (right): https://codereview.chromium.org/1921893004/diff/60001/appengine/findit/handlers/build_failure.py#newcode256 appengine/findit/handlers/build_failure.py:256: if ('status' not in try_job_result or Maybe add a ...
4 years, 8 months ago (2016-04-26 21:53:29 UTC) #6
stgao
https://codereview.chromium.org/1921893004/diff/60001/appengine/findit/handlers/build_failure.py File appengine/findit/handlers/build_failure.py (right): https://codereview.chromium.org/1921893004/diff/60001/appengine/findit/handlers/build_failure.py#newcode256 appengine/findit/handlers/build_failure.py:256: if ('status' not in try_job_result or On 2016/04/26 21:53:29, ...
4 years, 8 months ago (2016-04-26 22:05:46 UTC) #7
chanli
https://codereview.chromium.org/1921893004/diff/60001/appengine/findit/handlers/build_failure.py File appengine/findit/handlers/build_failure.py (right): https://codereview.chromium.org/1921893004/diff/60001/appengine/findit/handlers/build_failure.py#newcode256 appengine/findit/handlers/build_failure.py:256: if ('status' not in try_job_result or On 2016/04/26 21:53:29, ...
4 years, 8 months ago (2016-04-26 22:29:15 UTC) #8
stgao
lgtm
4 years, 8 months ago (2016-04-26 22:32:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921893004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921893004/80001
4 years, 8 months ago (2016-04-26 22:53:55 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 22:58:35 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/739589f3ba1354fd0d50595e5059d...

Powered by Google App Engine
This is Rietveld 408576698