Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3120)

Unified Diff: appengine/findit/handlers/test/build_failure_test.py

Issue 1921893004: [Findit] Fix Key error in build_failure handler. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add a special status to this case and add test. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/result_status.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/test/build_failure_test.py
diff --git a/appengine/findit/handlers/test/build_failure_test.py b/appengine/findit/handlers/test/build_failure_test.py
index 6c664eff73e2239dad7840d722b92ebcbc69501f..a310c39dbeb96047ec64e4018e78b275fc634dc1 100644
--- a/appengine/findit/handlers/test/build_failure_test.py
+++ b/appengine/findit/handlers/test/build_failure_test.py
@@ -74,6 +74,13 @@ SAMPLE_TRY_JOB_INFO = {
'task_id': 'task2',
'task_url': 'url/task2',
'tests': ['test1']
+ },
+ {
+ 'ref_name': 'step1',
+ 'try_job_key': 'm/b/120',
+ 'task_id': 'task2',
+ 'task_url': 'url/task2',
+ 'tests': ['test5']
}
]
}
@@ -407,7 +414,7 @@ class BuildFailureTest(wf_testcase.WaterfallTestCase):
'last_pass': 119,
'supported': True,
'suspected_cls': [],
- 'tests': ['test1']
+ 'tests': ['test1', 'test5']
}
]
}
@@ -518,6 +525,23 @@ class BuildFailureTest(wf_testcase.WaterfallTestCase):
'try_job':{
'ref_name': 'step1',
'try_job_key': 'm/b/120',
+ 'status': result_status.UNKNOWN,
+ 'task_id': 'task2',
+ 'task_url': 'url/task2',
+ 'tests': ['test5']
+ },
+ 'heuristic_analysis': {
+ 'suspected_cls': []
+ },
+ 'tests': ['test5'],
+ 'first_failure': 120,
+ 'last_pass': 119,
+ 'supported': True
+ },
+ {
+ 'try_job':{
+ 'ref_name': 'step1',
+ 'try_job_key': 'm/b/120',
'status': result_status.NO_TRY_JOB_REASON_MAP[
analysis_status.PENDING],
'task_id': 'task2',
« no previous file with comments | « appengine/findit/handlers/result_status.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698