Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: appengine/findit/handlers/result_status.py

Issue 1921893004: [Findit] Fix Key error in build_failure handler. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add a special status to this case and add test. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/build_failure.py ('k') | appengine/findit/handlers/test/build_failure_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/result_status.py
diff --git a/appengine/findit/handlers/result_status.py b/appengine/findit/handlers/result_status.py
index 15d16bd350dd6ef6f04c419e1a19de7ff228023a..62df0f5a279d2cedc7da0a53defec2c97a3c270b 100644
--- a/appengine/findit/handlers/result_status.py
+++ b/appengine/findit/handlers/result_status.py
@@ -7,12 +7,14 @@ from model import analysis_status
# Additional status for swarming tasks and try jobs.
NO_SWARMING_TASK_FOUND = 110
NON_SWARMING_NO_RERUN = 120
-#Additional reasons for no try job information.
+# Additional reasons for no try job information.
SWARMING_TASK_PENDING = 130
SWARMING_TASK_RUNNING = 140
SWARMING_TASK_ERROR = 150
NO_FAILURE_RESULT_MAP = 160
FLAKY = 200
+# Universal status for unknowns.
+UNKNOWN = 210
NO_TRY_JOB_REASON_MAP = {
NO_SWARMING_TASK_FOUND: NO_SWARMING_TASK_FOUND,
@@ -37,4 +39,5 @@ STATUS_MESSAGE_MAP = {
'Swarming task failed, try job will not be triggered.'),
NO_FAILURE_RESULT_MAP: 'No swarming task nor try job was triggered.',
FLAKY: 'Flaky tests.',
+ UNKNOWN: 'Unknown failure.'
}
« no previous file with comments | « appengine/findit/handlers/build_failure.py ('k') | appengine/findit/handlers/test/build_failure_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698