Renaming _openssl files to _impl

Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

TBR=kelvinp@chromium.org
R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728
Committed: https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9
Cr-Commit-Position: refs/heads/master@{#389776}

[davidben, 2016-04-25 16:14:19]

https://codereview.chromium.org/1921563003/diff/1/net/android/keystore_impl.h
File net/android/keystore_impl.h (right):

https://codereview.chromium.org/1921563003/diff/1/net/android/keystore_impl.h...
net/android/keystore_impl.h:6: #define NET_ANDROID_KEYSTORE_IMPL_H
This file I'd actually leave alone since it's glue between the keystore and
OpenSSL. Also keystore.h exists and this isn't the implementation for
keystore.h. (Though we should do away with this file and use SSLPrivateKey.)

https://codereview.chromium.org/1921563003/diff/1/net/socket/ssl_client_socke...
File net/socket/ssl_client_socket_unittest.cc (right):

https://codereview.chromium.org/1921563003/diff/1/net/socket/ssl_client_socke...
net/socket/ssl_client_socket_unittest.cc:2461: // buffer. Either call
PR_Available and SSL_pending, although the former
Replace this last sentence with just "Call SSL_pending."

On that note, we possibly should fix this now that the NSS caveat isn't there.

https://codereview.chromium.org/1921563003/diff/1/net/ssl/ssl_client_session_...
File net/ssl/ssl_client_session_cache_impl.h (right):

https://codereview.chromium.org/1921563003/diff/1/net/ssl/ssl_client_session_...
net/ssl/ssl_client_session_cache_impl.h:6: #define
NET_SSL_SSL_CLIENT_SESSION_CACHE_IMPL_H
I'd drop the "impl" altogether since we're not implementing any kind of generic
SSLClientSessionCache interface.

[svaldez, 2016-04-25 20:26:35]

https://codereview.chromium.org/1921563003/diff/1/net/android/keystore_impl.h
File net/android/keystore_impl.h (right):

https://codereview.chromium.org/1921563003/diff/1/net/android/keystore_impl.h...
net/android/keystore_impl.h:6: #define NET_ANDROID_KEYSTORE_IMPL_H
On 2016/04/25 16:14:19, davidben wrote:
> This file I'd actually leave alone since it's glue between the keystore and
> OpenSSL. Also keystore.h exists and this isn't the implementation for
> keystore.h. (Though we should do away with this file and use SSLPrivateKey.)

Done.

https://codereview.chromium.org/1921563003/diff/1/net/socket/ssl_client_socke...
File net/socket/ssl_client_socket_unittest.cc (right):

https://codereview.chromium.org/1921563003/diff/1/net/socket/ssl_client_socke...
net/socket/ssl_client_socket_unittest.cc:2461: // buffer. Either call
PR_Available and SSL_pending, although the former
On 2016/04/25 16:14:19, davidben wrote:
> Replace this last sentence with just "Call SSL_pending."
> 
> On that note, we possibly should fix this now that the NSS caveat isn't there.

Done.

https://codereview.chromium.org/1921563003/diff/1/net/ssl/ssl_client_session_...
File net/ssl/ssl_client_session_cache_impl.h (right):

https://codereview.chromium.org/1921563003/diff/1/net/ssl/ssl_client_session_...
net/ssl/ssl_client_session_cache_impl.h:6: #define
NET_SSL_SSL_CLIENT_SESSION_CACHE_IMPL_H
On 2016/04/25 16:14:19, davidben wrote:
> I'd drop the "impl" altogether since we're not implementing any kind of
generic
> SSLClientSessionCache interface.

Done.

[svaldez, 2016-04-25 20:27:21]

The CQ bit was checked by svaldez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 20:27:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921563003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921563003/20001

[davidben, 2016-04-25 21:23:44]

lgtm

[svaldez, 2016-04-25 21:25:26]

The CQ bit was unchecked by svaldez@chromium.org

[svaldez, 2016-04-25 21:25:30]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2016-04-25 21:26:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921563003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921563003/20001

[commit-bot: I haz the power, 2016-04-25 21:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 21:37:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[svaldez, 2016-04-26 14:28:43]

Description was changed from

==========
Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728
==========

to

==========
Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

TBR=kelvinp@chromium.org
R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728
==========

[svaldez, 2016-04-26 14:28:48]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2016-04-26 14:28:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921563003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921563003/20001

[commit-bot: I haz the power, 2016-04-26 14:33:50]

Description was changed from

==========
Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

TBR=kelvinp@chromium.org
R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728
==========

to

==========
Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

TBR=kelvinp@chromium.org
R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728
==========

[commit-bot: I haz the power, 2016-04-26 14:33:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 14:35:41]

Description was changed from

==========
Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

TBR=kelvinp@chromium.org
R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728
==========

to

==========
Renaming _openssl files to _impl

Since we no longer have NSS implementations, we rename all the _openssl
specific implementations to _impl to align with the rest of the code
base.

TBR=kelvinp@chromium.org
R=davidben@chromium.org, kelvinp@chromium.org
BUG=604728

Committed: https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9
Cr-Commit-Position: refs/heads/master@{#389776}
==========

[commit-bot: I haz the power, 2016-04-26 14:35:42]

Patchset 2 (id:??) landed as
https://crrev.com/e83af29319a191e36d2e4dc6519636f15e3de5d9
Cr-Commit-Position: refs/heads/master@{#389776}