Renaming _openssl files to _impl

net/android/keystore_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef NET_ANDROID_KEYSTORE_OPENSSL_H
-#define NET_ANDROID_KEYSTORE_OPENSSL_H
+#ifndef NET_ANDROID_KEYSTORE_IMPL_H
+#define NET_ANDROID_KEYSTORE_IMPL_H

[davidben, 2016/04/25 16:14:19]

This file I'd actually leave alone since it's glue between the keystore and
OpenSSL. Also keystore.h exists and this isn't the implementation for
keystore.h. (Though we should do away with this file and use SSLPrivateKey.)

[svaldez, 2016/04/25 20:26:35]

Done.

 
 #include <jni.h>
 #include <openssl/evp.h>
 
 #include "crypto/scoped_openssl_types.h"
 #include "net/base/net_export.h"
 
-// OpenSSL-specific functions to use the Android platform keystore.
-// The features provided here are highly specific to OpenSSL and are
+// The features provided here are highly implementation specific and are
 // segregated from net/android/keystore.h because the latter only provides
 // simply JNI stubs to call Java code which only uses platform APIs.
 
 namespace net {
 namespace android {
 
 // Create a custom OpenSSL EVP_PKEY instance that wraps a platform
 // java.security.PrivateKey object, and will call the platform APIs
 // through JNI to implement signing (and only signing).
 //
@@ skipping 14 matching lines @@
 // - Uses a custom method to implement the minimum functions required to
 //   *sign* the digest that is part of the "Verify Certificate" message
 //   during the OpenSSL handshake. Anything else will result in undefined
 //   behaviour.
 NET_EXPORT crypto::ScopedEVP_PKEY GetOpenSSLPrivateKeyWrapper(
     jobject private_key);
 
 }  // namespace android
 }  // namespace net
 
-#endif  // NET_ANDROID_KEYSTORE_OPENSSL_H
+#endif  // NET_ANDROID_KEYSTORE_IMPL_H