Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 1921563003: Renaming _openssl files to _impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | net/socket/ssl_server_socket_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index 63884f4637697a76f28306da0af5376aa420573a..e93b1bdbfc36cd1ddc7148c69d7b062802767089 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -1501,9 +1501,8 @@ TEST_F(SSLClientSocketTest, Read_DeleteWhilePendingFullDuplex) {
ASSERT_EQ(ERR_IO_PENDING, rv);
ASSERT_FALSE(read_callback.have_result());
- // Attempt to write the remaining data. NSS will not be able to consume the
- // application data because the internal buffers are full, while OpenSSL will
- // return that its blocked because the underlying transport is blocked.
+ // Attempt to write the remaining data. OpenSSL will return that its blocked
+ // because the underlying transport is blocked.
rv = raw_sock->Write(request_buffer.get(),
request_buffer->BytesRemaining(),
callback.callback());
@@ -2458,10 +2457,8 @@ TEST_F(SSLClientSocketTest, ReuseStates) {
// TODO(davidben): Read one byte to ensure the test server has responded and
// then assert IsConnectedAndIdle is false. This currently doesn't work
- // because neither SSLClientSocketNSS nor SSLClientSocketOpenSSL check their
- // SSL implementation's internal buffers. Either call PR_Available and
- // SSL_pending, although the former isn't actually implemented or perhaps
- // attempt to read one byte extra.
+ // because SSLClientSocketImpl doesn't check the implementation's internal
+ // buffer. Call SSL_pending.
}
// Tests that IsConnectedAndIdle treats a socket as idle even if a Write hasn't
@@ -2492,8 +2489,8 @@ TEST_F(SSLClientSocketTest, ReusableAfterWrite) {
scoped_refptr<IOBuffer> request_buffer(new IOBuffer(kRequestLen));
memcpy(request_buffer->data(), kRequestText, kRequestLen);
- // Although transport writes are blocked, both SSLClientSocketOpenSSL and
- // SSLClientSocketNSS complete the outer Write operation.
+ // Although transport writes are blocked, SSLClientSocketImpl completes the
+ // outer Write operation.
EXPECT_EQ(static_cast<int>(kRequestLen),
callback.GetResult(sock->Write(request_buffer.get(), kRequestLen,
callback.callback())));
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | net/socket/ssl_server_socket_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698