Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1920853002: Drop support for Compact Language Detector v1. (Closed)

Created:
4 years, 8 months ago by Andrew Hayden (chromium.org)
Modified:
4 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, arv+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni+watch_chromium.org, Takashi Toyoshima, droger, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop support for Compact Language Detector v1. Compact Language Detector (CLD) v2 has been the only version used by Chromium for several months. A PSA announcing deprecation was sent in September 2015, see the bug for more details. This change should be a no-op for all platforms, since all platforms are already migrated to CLD v2. BUG=605688 Committed: https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23 Cr-Commit-Position: refs/heads/master@{#389544}

Patch Set 1 #

Patch Set 2 : Revert unrelated syntax cleanups in common.gypi #

Patch Set 3 : Simplify chrome/BUILD.gn #

Patch Set 4 : Preserve yfriedman@ comment in chrome/android/chrome_apk.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -247 lines) Patch
M build/common.gypi View 1 3 chunks +0 lines, -8 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/BUILD.gn View 1 2 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/chrome_tests.gypi View 10 chunks +11 lines, -31 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +3 lines, -22 lines 0 comments Download
M chrome/test/BUILD.gn View 13 chunks +12 lines, -42 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -5 lines 0 comments Download
M components/translate.gypi View 5 chunks +4 lines, -23 lines 0 comments Download
M components/translate/content/renderer/BUILD.gn View 2 chunks +3 lines, -8 lines 0 comments Download
M components/translate/core/language_detection/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 5 chunks +1 line, -28 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +1 line, -6 lines 0 comments Download
M extensions/shell/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M extensions/shell/app_shell.gyp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Andrew Hayden (chromium.org)
Blah, the Eclipse formatter auto-updated the GYP/GN syntax in several files. LMK if you want ...
4 years, 8 months ago (2016-04-25 13:42:22 UTC) #3
Andrew Hayden (chromium.org)
I reverted the unrelated syntax cleanups in build/common.gypi, so that should make this easier.
4 years, 8 months ago (2016-04-25 13:52:57 UTC) #4
jam
lgtm
4 years, 8 months ago (2016-04-25 15:53:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920853002/60001
4 years, 8 months ago (2016-04-25 15:57:01 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
4 years, 8 months ago (2016-04-25 17:46:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920853002/60001
4 years, 8 months ago (2016-04-25 19:44:23 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-25 19:49:31 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 19:51:17 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23
Cr-Commit-Position: refs/heads/master@{#389544}

Powered by Google App Engine
This is Rietveld 408576698