components/translate/core/language_detection/BUILD.gn - Issue 1920853002: Drop support for Compact Language Detector v1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/language_detection/BUILD.gn

Issue 1920853002: Drop support for Compact Language Detector v1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Preserve yfriedman@ comment in chrome/android/chrome_apk.gyp Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/language_detection/BUILD.gn

diff --git a/components/translate/core/language_detection/BUILD.gn b/components/translate/core/language_detection/BUILD.gn

index dd8c57f0c85ea1931dd7240ebd87dd649384a857..71b4a01ed3d70f74e9f0b6c67d05476d5b1e041a 100644

--- a/components/translate/core/language_detection/BUILD.gn

+++ b/components/translate/core/language_detection/BUILD.gn

@@ -14,15 +14,8 @@ source_set("language_detection") {

"//base",

"//components/translate/core/common",

"//url",

+ "//third_party/cld_2:cld2_platform_impl",

]

- if (cld_version == 1) {

- deps += [ "//third_party/cld" ]

- } else if (cld_version == 2) {

- deps += [ "//third_party/cld_2:cld2_platform_impl" ]

- } else {

- assert(false, "Need a CLD version")

- }

}

source_set("unit_tests") {