Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4223)

Unified Diff: chrome/BUILD.gn

Issue 1920853002: Drop support for Compact Language Detector v1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Preserve yfriedman@ comment in chrome/android/chrome_apk.gyp Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/features.gni ('k') | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 7828eb1492df3361573bbee4d77eabdcaa6bd73b..b9dc287e3e37aa9d8e6df250498f4bd93499e898 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -305,6 +305,7 @@ if (is_mac || is_win) {
":browser_dependencies",
"//build/config/sanitizers:deps",
"//chrome/common:features",
+ "//third_party/cld_2",
]
if (is_win) {
output_name = "chrome"
@@ -350,10 +351,6 @@ if (is_mac || is_win) {
]
}
- if (cld_version == 2) {
- deps += [ "//third_party/cld_2" ]
- }
-
if (is_mac) {
#['OS=="mac" and component!="shared_library"', { TODO(GYP)
# 'includes': [ 'chrome_dll_bundle.gypi' ],
@@ -492,6 +489,7 @@ group("child_dependencies") {
public_deps = [
"//chrome/common",
"//sync",
+ "//third_party/cld_2:cld2_platform_impl",
]
if (!is_ios) {
public_deps += [
@@ -504,9 +502,6 @@ group("child_dependencies") {
"//third_party/WebKit/public:blink_devtools_frontend_resources",
]
}
- if (cld_version == 2) {
- public_deps += [ "//third_party/cld_2:cld2_platform_impl" ]
- }
if (enable_nacl) {
public_deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]
« no previous file with comments | « build/config/features.gni ('k') | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698