Mac: Add detection for low power video compatible frames

Mac: Add detection for low power video compatible frames

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CARendererLayerTree to check to see if the
frame can be represented by a single video frame on a black
background, and, if so, update the AVSampleBufferDisplayLayer
to show this video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5796159f793cc27a4b2f6ccdef91b8bf87b00721
Cr-Commit-Position: refs/heads/master@{#390187}

[ccameron, 2016-04-25 05:06:53]

Description was changed from

==========
Mac fullscreen low power: Add detection for low power mode

BUG=
==========

to

==========
Mac fullscreen low power: Add detection for low power mode

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-04-25 05:20:34]

Description was changed from

==========
Mac fullscreen low power: Add detection for low power mode

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mac fullscreen low power video: Add detection for low power mode

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CALayerTree to check to see if the CALayerTree
can be represented by a single video frame on a black background,
and, if so, update the AVSampleBufferDisplayLayer to show this
video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
==========

[ccameron, 2016-04-25 05:20:35]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2016-04-25 05:51:46]

Description was changed from

==========
Mac fullscreen low power video: Add detection for low power mode

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CALayerTree to check to see if the CALayerTree
can be represented by a single video frame on a black background,
and, if so, update the AVSampleBufferDisplayLayer to show this
video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
==========

to

==========
Mac fullscreen low power video: Add detection for low power mode

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CALayerTree to check to see if the CALayerTree
can be represented by a single video frame on a black background,
and, if so, update the AVSampleBufferDisplayLayer to show this
video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-04-26 23:30:25]

Description was changed from

==========
Mac fullscreen low power video: Add detection for low power mode

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CALayerTree to check to see if the CALayerTree
can be represented by a single video frame on a black background,
and, if so, update the AVSampleBufferDisplayLayer to show this
video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mac fullscreen low power video: Add detection for low power mode

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CALayerTree to check to see if the CALayerTree
can be represented by a single video frame on a black background,
and, if so, update the AVSampleBufferDisplayLayer to show this
video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
==========

[ccameron, 2016-04-26 23:32:25]

Description was changed from

==========
Mac fullscreen low power video: Add detection for low power mode

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CALayerTree to check to see if the CALayerTree
can be represented by a single video frame on a black background,
and, if so, update the AVSampleBufferDisplayLayer to show this
video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
==========

to

==========
Mac: Add detection for low power video compatible frames

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CARendererLayerTree to check to see if the
frame can be represented by a single video frame on a black
background, and, if so, update the AVSampleBufferDisplayLayer
to show this video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
==========

[erikchen, 2016-04-26 23:56:22]

lgtm

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_layer_tree_coordinator.h (right):

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.h:42: bool*
fullscreen_low_power_layer_valid);
Add the comment:
If the pending tree should be displayed as a fullscreen low power layer, then
the output variable |fullscreen_low_power_layer_valid| will be set to true.

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm (right):

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm:22:
[[AVSampleBufferDisplayLayer alloc] init]);
I wonder if there's any type of initialization cost to make this layer? If so,
we may want to consider lazy-initializing this variable. This may be premature
optimization.

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm:93: // NSWindows.
File a crbug, link it.

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right):

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:182: for (auto& clip_layer :
root_layer_.clip_and_sorting_layers) {
const auto& for all loops

[ccameron, 2016-04-27 04:46:35]

Description was changed from

==========
Mac: Add detection for low power video compatible frames

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CARendererLayerTree to check to see if the
frame can be represented by a single video frame on a black
background, and, if so, update the AVSampleBufferDisplayLayer
to show this video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
==========

to

==========
Mac: Add detection for low power video compatible frames

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CARendererLayerTree to check to see if the
frame can be represented by a single video frame on a black
background, and, if so, update the AVSampleBufferDisplayLayer
to show this video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-04-27 20:01:10]

Thanks!

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_layer_tree_coordinator.h (right):

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.h:42: bool*
fullscreen_low_power_layer_valid);
On 2016/04/26 23:56:21, erikchen wrote:
> Add the comment:
> If the pending tree should be displayed as a fullscreen low power layer, then
> the output variable |fullscreen_low_power_layer_valid| will be set to true.

Done.

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm (right):

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm:22:
[[AVSampleBufferDisplayLayer alloc] init]);
On 2016/04/26 23:56:21, erikchen wrote:
> I wonder if there's any type of initialization cost to make this layer? If so,
> we may want to consider lazy-initializing this variable. This may be premature
> optimization.

Mmh, it's a good point. Lazy init is a bit messy here -- let's keep it in mind.

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm:93: // NSWindows.
On 2016/04/26 23:56:21, erikchen wrote:
> File a crbug, link it.

So, there isn't an actual bug that I've observed, I just want to test it more
thoroughly when we're closer to enabling the feature.

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right):

https://codereview.chromium.org/1920723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:182: for (auto& clip_layer :
root_layer_.clip_and_sorting_layers) {
On 2016/04/26 23:56:21, erikchen wrote:
> const auto& for all loops

Done.

[ccameron, 2016-04-27 20:01:15]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-04-27 20:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1920723002/#ps100001
(title: "add const")

[commit-bot: I haz the power, 2016-04-27 20:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920723002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920723002/100001

[commit-bot: I haz the power, 2016-04-27 21:14:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:13:11]

Patchset 6 (id:??) landed as
https://crrev.com/5796159f793cc27a4b2f6ccdef91b8bf87b00721
Cr-Commit-Position: refs/heads/master@{#390187}

[commit-bot: I haz the power, 2016-04-30 17:51:57]

Description was changed from

==========
Mac: Add detection for low power video compatible frames

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CARendererLayerTree to check to see if the
frame can be represented by a single video frame on a black
background, and, if so, update the AVSampleBufferDisplayLayer
to show this video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Mac: Add detection for low power video compatible frames

Create a persistent AVSampleBufferDisplayLayer in CALayerTreeHost
for fullscreen low power video.

Add a function to CARendererLayerTree to check to see if the
frame can be represented by a single video frame on a black
background, and, if so, update the AVSampleBufferDisplayLayer
to show this video frame.

The AVSampleBufferDisplayLayer then doesn't go anywhere.
The next patch will plumb it through to the
AcceleratedWidgetMac.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5796159f793cc27a4b2f6ccdef91b8bf87b00721
Cr-Commit-Position: refs/heads/master@{#390187}
==========