Move logic from ImageTransportSurfaceOverlayMac into ui/

Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

Rename the structures to have clearer meanings. The CARendererLayerTree
(formerly CALayerTree) is produced by CoreAnimation renderer, and the
GLRendererLayerTree (formerly CALayerPartialDamageTree) is produced
by the OpenGL renderer. The CALayerTreeCoordinator coordinates switching
between these types of trees.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f3c6c059d5318978e9171ae7a1ca54f56091de85
Cr-Commit-Position: refs/heads/master@{#389959}

[ccameron, 2016-04-25 02:40:03]

Description was changed from

==========
Move more logic from ImageTransportSurfaceOverlayMac into ui

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This will help with moving all of this to the browser process.

This will also help with adding low power video mode.

This will also help being able to test these transitions (we currently
just test one mode or the other).

BUG=604052
==========

to

==========
Move more logic from ImageTransportSurfaceOverlayMac into ui

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This will help with moving all of this to the browser process.

This will also help with adding low power video mode.

This will also help being able to test these transitions (we currently
just test one mode or the other).

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-04-25 02:41:42]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2016-04-25 02:41:43]

I'm not enamored with the name CALayerTreeHost -- other suggestions welcome. I
also thought of CALayerTreeContainer or CALayerTreeCoordinator.

[erikchen, 2016-04-25 20:05:36]

Can you clean up your commit message? Maybe:

"""
Move logic from ImageTransportSurfaceOverlayMac into ui/.

The CL is a refactor and has no intended functional effect.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This has three benefits:
  + Continues the process of moving logic into the browser process.
  + Simplifies the logic needed to add low power video mode.
  + Simplifies testing of transitions between the two modes.
"""

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
File ui/accelerated_widget_mac/ca_layer_tree_host.h (right):

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
ui/accelerated_widget_mac/ca_layer_tree_host.h:14: // A structure that holds
CALayer tree for web content from the compositor. The
Maybe: A structure that holds a tree of CALayers that represents web contents
from a RenderWidgetHostViewMac, after the contents has been processed by the
compositor....

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
ui/accelerated_widget_mac/ca_layer_tree_host.h:17: class
ACCELERATED_WIDGET_MAC_EXPORT CALayerTreeHost {
disallow copy and assign?

Also, I prefer that you don't use the word *Host*, since we tend to use that to
mean an object responsible for managing another process. CALayerTreeCoordinator
sounds fine.

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
ui/accelerated_widget_mac/ca_layer_tree_host.h:19: CALayerTreeHost(bool
allow_remote_layers);
explicit

It looks like the public interface of this class is highly dependent on
allow_remote_layers. At the very least, you should organize the public interface
into 3 sections:

1. Methods that can always be called.
2. Methods that should only be called if allow_remote_layers=true
3. Methods that should only be called if allow_remote_layers=false.

The implementations of the methods in (2) and (3) should have DCHECKs.

[erikchen, 2016-04-25 20:06:01]

Otherwise, lgtm.

[ccameron, 2016-04-26 17:31:32]

Description was changed from

==========
Move more logic from ImageTransportSurfaceOverlayMac into ui

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This will help with moving all of this to the browser process.

This will also help with adding low power video mode.

This will also help being able to test these transitions (we currently
just test one mode or the other).

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
==========

[ccameron, 2016-04-26 22:18:59]

Description was changed from

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
==========

to

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-04-26 22:20:18]

Description was changed from

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

Rename the structures to have clearer meanings. The CARendererLayerTree
(formerly CALayerTree) is produced by CoreAnimation renderer, and the
GLRendererLayerTree (formerly CALayerPartialDamageTree) is produced
by the OpenGL renderer. The CALayerTreeCoordinator coordinates switching
between these types of trees.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-04-26 22:36:40]

Updated with lots more renaming, and I think it clears things up quite a bit.

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
File ui/accelerated_widget_mac/ca_layer_tree_host.h (right):

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
ui/accelerated_widget_mac/ca_layer_tree_host.h:14: // A structure that holds
CALayer tree for web content from the compositor. The
On 2016/04/25 20:05:36, erikchen wrote:
> Maybe: A structure that holds a tree of CALayers that represents web contents
> from a RenderWidgetHostViewMac, after the contents has been processed by the
> compositor....

I changed it to "composited content", because a RWHVMac may not be involved for
browser-side composited stuff.

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
ui/accelerated_widget_mac/ca_layer_tree_host.h:17: class
ACCELERATED_WIDGET_MAC_EXPORT CALayerTreeHost {
On 2016/04/25 20:05:36, erikchen wrote:
> disallow copy and assign?

Done.

> Also, I prefer that you don't use the word *Host*, since we tend to use that
to
> mean an object responsible for managing another process.
CALayerTreeCoordinator
> sounds fine.

Replaced Host with Coordinator (especially now that we have two different
structures that are called XLayerTree, and this coordinates switching between
them).

https://codereview.chromium.org/1917723002/diff/1/ui/accelerated_widget_mac/c...
ui/accelerated_widget_mac/ca_layer_tree_host.h:19: CALayerTreeHost(bool
allow_remote_layers);
On 2016/04/25 20:05:36, erikchen wrote:
> explicit

Done

> It looks like the public interface of this class is highly dependent on
> allow_remote_layers. At the very least, you should organize the public
interface
> into 3 sections:
> 
> 1. Methods that can always be called.
> 2. Methods that should only be called if allow_remote_layers=true
> 3. Methods that should only be called if allow_remote_layers=false.
> 
> The implementations of the methods in (2) and (3) should have DCHECKs.

The structure of the file is
- Stuff that is called before a frame is generated
- Stuff that is called to generate content in a frame
(SetPendingBackbuffer/GetPendingCALayerTree)
- Stuff to complete the frame (CommitPendingTreesToCA)
- Stuff to display the completed frame (GetRootCALayer and
GetFrontbufferIOSurface).

I've added some DCHECKs and comments about remote layers. In the near future, we
should be able to get rid of the remote layer stuff (cause this will be in the
browser process).

[erikchen, 2016-04-26 23:09:47]

thanks, this is a lot better. lgtm

https://codereview.chromium.org/1917723002/diff/40001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_layer_tree_coordinator.h (right):

https://codereview.chromium.org/1917723002/diff/40001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_layer_tree_coordinator.h:35: // The the
CARendererLayerTree for the pending frame. This is used to
s/the//

[ccameron, 2016-04-26 23:55:03]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-04-26 23:55:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1917723002/#ps60001
(title: "Fix grammar")

[commit-bot: I haz the power, 2016-04-26 23:55:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917723002/60001

[commit-bot: I haz the power, 2016-04-27 00:51:12]

Description was changed from

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

Rename the structures to have clearer meanings. The CARendererLayerTree
(formerly CALayerTree) is produced by CoreAnimation renderer, and the
GLRendererLayerTree (formerly CALayerPartialDamageTree) is produced
by the OpenGL renderer. The CALayerTreeCoordinator coordinates switching
between these types of trees.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

Rename the structures to have clearer meanings. The CARendererLayerTree
(formerly CALayerTree) is produced by CoreAnimation renderer, and the
GLRendererLayerTree (formerly CALayerPartialDamageTree) is produced
by the OpenGL renderer. The CALayerTreeCoordinator coordinates switching
between these types of trees.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-27 00:51:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-27 00:52:46]

Description was changed from

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

Rename the structures to have clearer meanings. The CARendererLayerTree
(formerly CALayerTree) is produced by CoreAnimation renderer, and the
GLRendererLayerTree (formerly CALayerPartialDamageTree) is produced
by the OpenGL renderer. The CALayerTreeCoordinator coordinates switching
between these types of trees.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move logic from ImageTransportSurfaceOverlayMac into ui/

This CL is a refactor and should have no functional effects.

Move the logic that handles switching between CALayerTree (from the
CoreAnimation renderer) and CALayerPartialDamageTree (from the OpenGL
renderer) into ui/accelerated_widget_mac.

Rename the structures to have clearer meanings. The CARendererLayerTree
(formerly CALayerTree) is produced by CoreAnimation renderer, and the
GLRendererLayerTree (formerly CALayerPartialDamageTree) is produced
by the OpenGL renderer. The CALayerTreeCoordinator coordinates switching
between these types of trees.

This is to
- Continue the process of moving CoreAnimation renderer entirely to the
  browser process
- Provide a place to plug in and update low power video layers.
- Allow for testing of the transition between CoreAnimation renderer
  and OpenGL renderer.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f3c6c059d5318978e9171ae7a1ca54f56091de85
Cr-Commit-Position: refs/heads/master@{#389959}
==========

[commit-bot: I haz the power, 2016-04-27 00:52:47]

Patchset 4 (id:??) landed as
https://crrev.com/f3c6c059d5318978e9171ae7a1ca54f56091de85
Cr-Commit-Position: refs/heads/master@{#389959}