Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1919153002: Tidy up WebGeolocationController. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up WebGeolocationController. Get rid of impedance-matching wrapper now that Oilpan is enabled always. R= BUG=585328 Committed: https://crrev.com/dfc87556f5f410ed0fa44511cab9558e8c109276 Cr-Commit-Position: refs/heads/master@{#389777}

Patch Set 1 #

Total comments: 1

Patch Set 2 : still support implicit conversion #

Messages

Total messages: 11 (5 generated)
sof
please take a look (tkent@ for public/)
4 years, 8 months ago (2016-04-26 09:01:22 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-26 09:03:40 UTC) #3
tkent
lgtm https://codereview.chromium.org/1919153002/diff/1/third_party/WebKit/public/web/WebGeolocationController.h File third_party/WebKit/public/web/WebGeolocationController.h (right): https://codereview.chromium.org/1919153002/diff/1/third_party/WebKit/public/web/WebGeolocationController.h#newcode47 third_party/WebKit/public/web/WebGeolocationController.h:47: explicit WebGeolocationController(GeolocationController*); We usually allow implicit conversion between ...
4 years, 8 months ago (2016-04-26 12:49:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919153002/20001
4 years, 8 months ago (2016-04-26 13:01:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 14:46:45 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 14:47:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfc87556f5f410ed0fa44511cab9558e8c109276
Cr-Commit-Position: refs/heads/master@{#389777}

Powered by Google App Engine
This is Rietveld 408576698