third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp - Issue 1919153002: Tidy up WebGeolocationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

Issue 1919153002: Tidy up WebGeolocationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: still support implicit conversion Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp b/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

index e2c12fd6c9b548e962ae1ed152833c5dd9da27a1..45fe62a5bddb9fa80b1afc5949eb1b88bcec83b2 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp

@@ -140,8 +140,8 @@ void GeolocationController::errorOccurred(GeolocationError* error)

GeolocationPosition* GeolocationController::lastPosition()

{

- if (m_lastPosition.get())

- return m_lastPosition.get();

+ if (m_lastPosition)

+ return m_lastPosition;

if (!m_client)

return 0;