Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/WebKit/Source/modules/geolocation/testing/GeolocationClientMock.cpp

Issue 1919153002: Tidy up WebGeolocationController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: still support implicit conversion Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/testing/GeolocationClientMock.cpp
diff --git a/third_party/WebKit/Source/modules/geolocation/testing/GeolocationClientMock.cpp b/third_party/WebKit/Source/modules/geolocation/testing/GeolocationClientMock.cpp
index 269f122c07823a96b26ec345078b9fe0805a76be..3615bbe81ee176795bfee0dfa0567413c380af9a 100644
--- a/third_party/WebKit/Source/modules/geolocation/testing/GeolocationClientMock.cpp
+++ b/third_party/WebKit/Source/modules/geolocation/testing/GeolocationClientMock.cpp
@@ -147,7 +147,7 @@ void GeolocationClientMock::setEnableHighAccuracy(bool)
GeolocationPosition* GeolocationClientMock::lastPosition()
{
- return m_lastPosition.get();
+ return m_lastPosition;
}
void GeolocationClientMock::asyncUpdateController()
@@ -162,10 +162,10 @@ void GeolocationClientMock::controllerTimerFired(Timer<GeolocationClientMock>* t
// Make a copy of the set of controllers since it might be modified while iterating.
GeolocationControllers controllers = m_controllers;
- if (m_lastPosition.get()) {
+ if (m_lastPosition) {
ASSERT(!m_hasError);
for (GeolocationControllers::iterator it = controllers.begin(); it != controllers.end(); ++it)
- (*it)->positionChanged(m_lastPosition.get());
+ (*it)->positionChanged(m_lastPosition);
} else if (m_hasError) {
for (GeolocationControllers::iterator it = controllers.begin(); it != controllers.end(); ++it)
(*it)->errorOccurred(GeolocationError::create(GeolocationError::PositionUnavailable, m_errorMessage));

Powered by Google App Engine
This is Rietveld 408576698