Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918923003: Remove unnecessary casts and general code clean-up (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -577 lines) Patch
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 1 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 5 chunks +8 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 5 chunks +22 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 6 chunks +28 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/value.dart View 3 chunks +27 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +18 lines, -20 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 12 chunks +30 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 23 chunks +78 lines, -87 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 24 chunks +73 lines, -92 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +29 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 36 chunks +115 lines, -155 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 3 chunks +13 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 6 chunks +57 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-25 18:47:23 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1918923003/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/1918923003/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode4708 pkg/analyzer/lib/src/generated/parser.dart:4708: ; Remove this?
4 years, 8 months ago (2016-04-25 19:14:44 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1918923003/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/1918923003/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode4708 pkg/analyzer/lib/src/generated/parser.dart:4708: ; Done
4 years, 8 months ago (2016-04-25 19:24:20 UTC) #4
Brian Wilkerson
4 years, 8 months ago (2016-04-25 19:24:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cda79ce966174fe66ebd642503efb932500c3aad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698