pkg/analyzer/lib/src/dart/resolver/scope.dart - Issue 1918923003: Remove unnecessary casts and general code clean-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/dart/resolver/scope.dart

Issue 1918923003: Remove unnecessary casts and general code clean-up (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: clean-up Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/dart/resolver/scope.dart

diff --git a/pkg/analyzer/lib/src/dart/resolver/scope.dart b/pkg/analyzer/lib/src/dart/resolver/scope.dart

index a3f0b07cda56dfddb14f93ad16a1d02ca2215709..54086d9dc144daadd579c61b2a1cbb33a6fdeba2 100644

--- a/pkg/analyzer/lib/src/dart/resolver/scope.dart

+++ b/pkg/analyzer/lib/src/dart/resolver/scope.dart

@@ -390,9 +390,9 @@ class LibraryImportScope extends Scope {

}

- if (foundElement is MultiplyDefinedElementImpl) {

- foundElement = _removeSdkElements(

- identifier, name, foundElement as MultiplyDefinedElementImpl);

+ Element element = foundElement;

+ if (element is MultiplyDefinedElementImpl) {

+ foundElement = _removeSdkElements(identifier, name, element);

}

if (foundElement is MultiplyDefinedElementImpl) {

String foundEltName = foundElement.displayName;