Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analyzer/lib/src/generated/type_system.dart

Issue 1918923003: Remove unnecessary casts and general code clean-up (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: clean-up Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/static_type_analyzer.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/type_system.dart
diff --git a/pkg/analyzer/lib/src/generated/type_system.dart b/pkg/analyzer/lib/src/generated/type_system.dart
index 650397e53c0e91364f91519c442a40bd7628ad2e..526d067050019423bc75cbd3b3776501636d082f 100644
--- a/pkg/analyzer/lib/src/generated/type_system.dart
+++ b/pkg/analyzer/lib/src/generated/type_system.dart
@@ -310,8 +310,12 @@ class StrongTypeSystemImpl extends TypeSystem {
bool isGroundType(DartType t) {
// TODO(leafp): Revisit this.
- if (t is TypeParameterType) return false;
- if (_isTop(t)) return true;
+ if (t is TypeParameterType) {
+ return false;
+ }
+ if (_isTop(t)) {
+ return true;
+ }
if (t is FunctionType) {
if (!_isTop(t.returnType) ||
@@ -323,8 +327,8 @@ class StrongTypeSystemImpl extends TypeSystem {
}
if (t is InterfaceType) {
- var typeArguments = t.typeArguments;
- for (var typeArgument in typeArguments) {
+ List<DartType> typeArguments = t.typeArguments;
+ for (DartType typeArgument in typeArguments) {
if (!_isTop(typeArgument)) return false;
}
return true;
« no previous file with comments | « pkg/analyzer/lib/src/generated/static_type_analyzer.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698