Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1918393002: [page_load_metrics] Eagerly send IPCs on navigation commit (Closed)

Created:
4 years, 7 months ago by Charlie Harrison
Modified:
4 years, 7 months ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[page_load_metrics] Eagerly send IPCs on navigation commit This starts the page_load_metrics IPC timer a bit earlier, so we know to start tracking a committed load in the browser process. BUG=607550 Committed: https://crrev.com/f699127554b22fed13c910611ca8ce429041509e Cr-Commit-Position: refs/heads/master@{#390372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -30 lines) Patch
M components/page_load_metrics/renderer/metrics_render_frame_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc View 5 chunks +31 lines, -8 lines 0 comments Download
M components/page_load_metrics/renderer/page_timing_metrics_sender.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/page_load_metrics/renderer/page_timing_metrics_sender.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc View 3 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Bryan McQuade
this looks reasonable to me. happy to review when you are ready.
4 years, 7 months ago (2016-04-27 12:37:37 UTC) #2
Charlie Harrison
Go for it.
4 years, 7 months ago (2016-04-27 19:41:20 UTC) #3
Bryan McQuade
lgtm
4 years, 7 months ago (2016-04-27 20:56:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918393002/1
4 years, 7 months ago (2016-04-28 13:45:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 14:22:34 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:18:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f699127554b22fed13c910611ca8ce429041509e
Cr-Commit-Position: refs/heads/master@{#390372}

Powered by Google App Engine
This is Rietveld 408576698