Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1918393002: [page_load_metrics] Eagerly send IPCs on navigation commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc
diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
index aa146925d713a073770466c226e75f2d16c10c43..ee1cc6c0c2c8af3907c2710ef69f55c30ba2f461 100644
--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
@@ -65,8 +65,10 @@ void MetricsRenderFrameObserver::DidCommitProvisionalLoad(
// non-null, we will send metrics for the current page at some later time, as
// those metrics become available.
if (ShouldSendMetrics()) {
+ PageLoadTiming timing(GetTiming());
+ DCHECK(!timing.navigation_start.is_null());
page_timing_metrics_sender_.reset(
- new PageTimingMetricsSender(this, routing_id(), CreateTimer()));
+ new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing));
}
}
« no previous file with comments | « no previous file | components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698