[page_load_metrics] Eagerly send IPCs on navigation commit

components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
 
 #include "base/time/time.h"
 #include "base/timer/mock_timer.h"
 #include "components/page_load_metrics/common/page_load_metrics_messages.h"
 #include "components/page_load_metrics/common/page_load_timing.h"
@@ skipping 17 matching lines @@
     return true;
   }
 
   MOCK_METHOD2(OnTimingUpdated, void(PageLoadTiming, PageLoadMetadata));
 };
 
 // Thin wrapper around PageTimingMetricsSender that provides access to the
 // MockTimer instance.
 class TestPageTimingMetricsSender : public PageTimingMetricsSender {
  public:
-  explicit TestPageTimingMetricsSender(IPC::Sender* ipc_sender)
+  explicit TestPageTimingMetricsSender(IPC::Sender* ipc_sender,
+                                       const PageLoadTiming& initial_timing)
       : PageTimingMetricsSender(
             ipc_sender,
             MSG_ROUTING_NONE,
-            std::unique_ptr<base::Timer>(new base::MockTimer(false, false))) {}
+            std::unique_ptr<base::Timer>(new base::MockTimer(false, false)),
+            initial_timing) {}
 
   base::MockTimer* mock_timer() const {
     return reinterpret_cast<base::MockTimer*>(timer());
   }
 };
 
 class PageTimingMetricsSenderTest : public testing::Test {
  public:
-  PageTimingMetricsSenderTest() : metrics_sender_(&mock_ipc_sender_) {}
+  PageTimingMetricsSenderTest()
+      : metrics_sender_(&mock_ipc_sender_, PageLoadTiming()) {}
 
  protected:
   testing::StrictMock<MockIPCSender> mock_ipc_sender_;
   TestPageTimingMetricsSender metrics_sender_;
 };
 
 TEST_F(PageTimingMetricsSenderTest, Basic) {
   base::Time nav_start = base::Time::FromDoubleT(10);
   base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2);
 
@@ skipping 64 matching lines @@
   metrics_sender_.Send(timing);
   ASSERT_TRUE(metrics_sender_.mock_timer()->IsRunning());
   EXPECT_CALL(mock_ipc_sender_, OnTimingUpdated(timing, PageLoadMetadata()));
   metrics_sender_.mock_timer()->Fire();
   EXPECT_FALSE(metrics_sender_.mock_timer()->IsRunning());
 }
 
 TEST_F(PageTimingMetricsSenderTest, SendIPCOnDestructor) {
   PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(10);
-  {
-    // This test wants to verify behavior in the PageTimingMetricsSender
-    // destructor, so we create our own instance to make it go out of scope
-    // before the end of the test body.
-    TestPageTimingMetricsSender sender(&mock_ipc_sender_);
+  timing.first_layout = base::TimeDelta::FromMilliseconds(10);
 
-    sender.Send(timing);
-    EXPECT_CALL(mock_ipc_sender_, OnTimingUpdated(timing, PageLoadMetadata()));
-    ASSERT_TRUE(sender.mock_timer()->IsRunning());
-  }
+  // This test wants to verify behavior in the PageTimingMetricsSender
+  // destructor, the EXPECT_CALL will be verified when the test tears down and
+  // |metrics_sender_| goes out of scope.
+  metrics_sender_.Send(timing);
+  EXPECT_CALL(mock_ipc_sender_, OnTimingUpdated(timing, PageLoadMetadata()));
+  ASSERT_TRUE(metrics_sender_.mock_timer()->IsRunning());
 }
 
 }  // namespace page_load_metrics