Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918003003: Bring sk_sp to GrDrawContext (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -164 lines) Patch
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 2 comments Download
M gm/bigrrectaaeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/rrects.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/texdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 8 chunks +16 lines, -16 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 4 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 31 chunks +36 lines, -34 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 2 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathRenderingDrawContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureToYUVPlanes.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 7 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 12 chunks +28 lines, -28 lines 0 comments Download
M tests/GLProgramsTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RectangleTextureTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
robertphillips
The only interesting files are: GrContext.h GrContext.cpp GrDrawContext.h GrDrawContext.cpp GrDrawingManager.h GrDrawingManager.cpp GrPathRenderingDrawContext.h SkGpuDevice.h SkGpuDevice.cpp
4 years, 8 months ago (2016-04-25 21:27:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918003003/20001
4 years, 8 months ago (2016-04-25 21:39:18 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8104)
4 years, 8 months ago (2016-04-25 21:43:49 UTC) #8
bsalomon
https://codereview.chromium.org/1918003003/diff/20001/gm/beziereffects.cpp File gm/beziereffects.cpp (right): https://codereview.chromium.org/1918003003/diff/20001/gm/beziereffects.cpp#newcode112 gm/beziereffects.cpp:112: sk_sp<GrDrawContext> drawContext(context->drawContext(sk_ref_sp(rt))); It seems strange that we need to ...
4 years, 8 months ago (2016-04-26 13:09:25 UTC) #9
robertphillips
https://codereview.chromium.org/1918003003/diff/20001/gm/beziereffects.cpp File gm/beziereffects.cpp (right): https://codereview.chromium.org/1918003003/diff/20001/gm/beziereffects.cpp#newcode112 gm/beziereffects.cpp:112: sk_sp<GrDrawContext> drawContext(context->drawContext(sk_ref_sp(rt))); On 2016/04/26 13:09:25, bsalomon wrote: > It ...
4 years, 8 months ago (2016-04-26 13:36:53 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918003003/20001
4 years, 8 months ago (2016-04-26 14:19:58 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 14:24:33 UTC) #14
robertphillips
ping
4 years, 7 months ago (2016-04-27 15:44:00 UTC) #15
bsalomon
On 2016/04/27 15:44:00, robertphillips wrote: > ping lgtm
4 years, 7 months ago (2016-04-27 16:44:18 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918003003/20001
4 years, 7 months ago (2016-04-27 16:56:26 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 17:08:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918003003/20001
4 years, 7 months ago (2016-04-27 17:46:31 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 17:47:55 UTC) #24
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6c7e325236b7fbb9c9b14ebb4715f88a59718695

Powered by Google App Engine
This is Rietveld 408576698