Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917973002: mac: Remove IsOSLion(). (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek, tapted, ortuno, jam
CC:
chromium-reviews, ortuno+watch_chromium.org, piman+watch_chromium.org, rickyz+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove IsOSLion(). BUG=579255 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jam Committed: https://crrev.com/114a1ef9e848ccebec516681bcf1786f85b5cbd6 Cr-Commit-Position: refs/heads/master@{#389797}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Total comments: 15

Patch Set 6 : . #

Total comments: 1

Patch Set 7 : tapted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -453 lines) Patch
M base/files/file_path_watcher.cc View 1 2 3 4 5 6 2 chunks +3 lines, -9 lines 0 comments Download
M base/mac/mac_util.h View 3 chunks +0 lines, -18 lines 0 comments Download
M base/mac/mac_util.mm View 1 chunk +0 lines, -12 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 4 chunks +1 line, -29 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/fullscreen_mac.mm View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm View 1 4 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 1 2 3 4 4 chunks +18 lines, -26 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm View 1 2 3 4 5 6 5 chunks +3 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/exclusive_access_bubble_view.mm View 1 2 3 4 5 6 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 1 2 3 4 5 6 3 chunks +1 line, -28 lines 0 comments Download
M chrome/browser/ui/cocoa/spinner_view.mm View 1 2 3 4 5 6 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 2 3 4 5 6 3 chunks +19 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M components/storage_monitor/storage_monitor_mac.mm View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/gpu.sb View 1 1 chunk +11 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 6 chunks +10 lines, -46 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 3 4 5 6 5 chunks +0 lines, -17 lines 0 comments Download
M content/common/common.sb View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/cursors/webcursor_mac.mm View 1 2 3 4 5 6 3 chunks +4 lines, -12 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 1 chunk +6 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_factory.cc View 1 2 3 4 5 2 chunks +1 line, -7 lines 0 comments Download
M gpu/config/gpu_test_config.cc View 1 2 3 4 5 6 2 chunks +2 lines, -9 lines 0 comments Download
M media/base/mac/avfoundation_glue.mm View 1 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/host/curtain_mode_mac.cc View 1 2 3 4 5 6 2 chunks +0 lines, -15 lines 0 comments Download
M sandbox/mac/os_compatibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.mm View 1 chunk +1 line, -5 lines 0 comments Download
M ui/app_list/cocoa/scroll_view_with_no_scrollbars.mm View 1 2 3 4 5 6 3 chunks +1 line, -8 lines 0 comments Download
M ui/base/cocoa/base_view.mm View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 2 3 4 5 6 2 chunks +2 lines, -8 lines 0 comments Download
M ui/gfx/font_fallback_mac.mm View 2 chunks +5 lines, -27 lines 0 comments Download
M ui/gfx/mac/nswindow_frame_controls.mm View 1 2 3 4 5 6 2 chunks +2 lines, -6 lines 0 comments Download
M ui/gl/gpu_switching_manager.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Nico
rsesek: *sandbox*, *.sb tapted: rest
4 years, 8 months ago (2016-04-25 20:15:52 UTC) #3
ortuno
https://codereview.chromium.org/1917973002/diff/80001/device/bluetooth/bluetooth_adapter_factory.cc File device/bluetooth/bluetooth_adapter_factory.cc (left): https://codereview.chromium.org/1917973002/diff/80001/device/bluetooth/bluetooth_adapter_factory.cc#oldcode66 device/bluetooth/bluetooth_adapter_factory.cc:66: return base::mac::IsOSLionOrLater(); You can also delete the "base/mac/mac_util.h" include.
4 years, 8 months ago (2016-04-25 20:32:32 UTC) #5
Nico
https://codereview.chromium.org/1917973002/diff/80001/device/bluetooth/bluetooth_adapter_factory.cc File device/bluetooth/bluetooth_adapter_factory.cc (left): https://codereview.chromium.org/1917973002/diff/80001/device/bluetooth/bluetooth_adapter_factory.cc#oldcode66 device/bluetooth/bluetooth_adapter_factory.cc:66: return base::mac::IsOSLionOrLater(); On 2016/04/25 20:32:32, ortuno wrote: > You ...
4 years, 8 months ago (2016-04-25 20:34:39 UTC) #6
Robert Sesek
LGTM
4 years, 8 months ago (2016-04-25 20:55:40 UTC) #7
tapted
lgtm - there might be a few more mac_util.h includes that could be removed - ...
4 years, 8 months ago (2016-04-25 21:25:47 UTC) #8
Nico
All done, thanks. https://codereview.chromium.org/1917973002/diff/80001/base/files/file_path_watcher.cc File base/files/file_path_watcher.cc (right): https://codereview.chromium.org/1917973002/diff/80001/base/files/file_path_watcher.cc#newcode15 base/files/file_path_watcher.cc:15: #include "base/mac/mac_util.h" On 2016/04/25 21:25:46, tapted ...
4 years, 8 months ago (2016-04-26 14:30:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917973002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917973002/120001
4 years, 8 months ago (2016-04-26 14:30:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/173272)
4 years, 8 months ago (2016-04-26 14:39:05 UTC) #14
Nico
tbr jam for global approval (change was reviewed already and is largely mechanical)
4 years, 8 months ago (2016-04-26 14:42:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917973002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917973002/120001
4 years, 8 months ago (2016-04-26 14:43:07 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-26 16:03:14 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 16:04:12 UTC) #23
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/114a1ef9e848ccebec516681bcf1786f85b5cbd6
Cr-Commit-Position: refs/heads/master@{#389797}

Powered by Google App Engine
This is Rietveld 408576698