Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1917953002: Skia: Supply --gcc to android_ninja when appropriate (Closed)

Created:
4 years, 8 months ago by borenet2
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Skia: Supply --gcc to android_ninja when appropriate BUG=skia:5215 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M scripts/slave/recipe_modules/skia/android_flavor.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-Android.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/download_and_push_skimage.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/download_and_push_skps.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_get_hashes.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/has_ccache_android.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SK_IMAGE_VERSION_device.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Release-Android.json View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
borenet
4 years, 8 months ago (2016-04-25 17:47:14 UTC) #2
rmistry
lgtm
4 years, 8 months ago (2016-04-25 17:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917953002/1
4 years, 8 months ago (2016-04-25 17:50:36 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 17:56:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300155

Powered by Google App Engine
This is Rietveld 408576698