Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: scripts/slave/recipe_modules/skia/android_flavor.py

Issue 1917953002: Skia: Supply --gcc to android_ninja when appropriate (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-Android.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 import android_devices 6 import android_devices
7 import copy 7 import copy
8 import default_flavor 8 import default_flavor
9 9
10 10
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 def compile(self, target): 104 def compile(self, target):
105 """Build the given target.""" 105 """Build the given target."""
106 env = dict(self._default_env) 106 env = dict(self._default_env)
107 ccache = self._skia_api.ccache() 107 ccache = self._skia_api.ccache()
108 if ccache: 108 if ccache:
109 env['ANDROID_MAKE_CCACHE'] = ccache 109 env['ANDROID_MAKE_CCACHE'] = ccache
110 110
111 cmd = [self.android_bin.join('android_ninja'), target, '-d', self.device] 111 cmd = [self.android_bin.join('android_ninja'), target, '-d', self.device]
112 if 'Clang' in self._skia_api.builder_name: 112 if 'Clang' in self._skia_api.builder_name:
113 cmd.append('--clang') 113 cmd.append('--clang')
114 if 'GCC' in self._skia_api.builder_name:
115 cmd.append('--gcc')
114 self._skia_api.run(self._skia_api.m.step, 'build %s' % target, cmd=cmd, 116 self._skia_api.run(self._skia_api.m.step, 'build %s' % target, cmd=cmd,
115 env=env, cwd=self._skia_api.m.path['checkout']) 117 env=env, cwd=self._skia_api.m.path['checkout'])
116 118
117 def device_path_join(self, *args): 119 def device_path_join(self, *args):
118 """Like os.path.join(), but for paths on a connected Android device.""" 120 """Like os.path.join(), but for paths on a connected Android device."""
119 return '/'.join(args) 121 return '/'.join(args)
120 122
121 def device_path_exists(self, path): 123 def device_path_exists(self, path):
122 """Like os.path.exists(), but for paths on a connected device.""" 124 """Like os.path.exists(), but for paths on a connected device."""
123 exists_str = 'FILE_EXISTS' 125 exists_str = 'FILE_EXISTS'
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 ).stdout.rstrip() 269 ).stdout.rstrip()
268 prefix = self.device_path_join(device_scratch_dir, 'skiabot', 'skia_') 270 prefix = self.device_path_join(device_scratch_dir, 'skiabot', 'skia_')
269 return default_flavor.DeviceDirs( 271 return default_flavor.DeviceDirs(
270 dm_dir=prefix + 'dm', 272 dm_dir=prefix + 'dm',
271 perf_data_dir=prefix + 'perf', 273 perf_data_dir=prefix + 'perf',
272 resource_dir=prefix + 'resources', 274 resource_dir=prefix + 'resources',
273 images_dir=prefix + 'images', 275 images_dir=prefix + 'images',
274 skp_dir=prefix + 'skp/skps', 276 skp_dir=prefix + 'skp/skps',
275 tmp_dir=prefix + 'tmp_dir') 277 tmp_dir=prefix + 'tmp_dir')
276 278
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-Android.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698