scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json - Issue 1917953002: Skia: Supply --gcc to android_ninja when appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

Issue 1917953002: Skia: Supply --gcc to android_ninja when appropriate (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/skia.expected/has_ccache_android.json ('k') | scripts/slave/recipes/skia/skia.expected/missing_SK_IMAGE_VERSION_device.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

diff --git a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

index e7109167b4a2e7e48697088568c4b6bb3d024106..de4762ea93d11d7f8514382748000c7f528076f3 100644

--- a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

+++ b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

@@ -169,7 +169,8 @@

"[SLAVE_BUILD]/skia/platform_tools/android/bin/android_ninja",

"dm",

"-d",

- "arm_v7_neon"

+ "arm_v7_neon",

+ "--gcc"

"cwd": "[SLAVE_BUILD]/skia",

"env": {

@@ -187,7 +188,8 @@