Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917883004: Deprecate CheckRietveldTryJobExecution "temporarily fixed" in 2012. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate CheckRietveldTryJobExecution "temporarily fixed" in 2012. See https://codereview.chromium.org/8353039/ R=maruel@chromium.org BUG=605563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300238

Patch Set 1 #

Patch Set 2 : thanks, pylint! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M presubmit_canned_checks.py View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-26 17:08:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917883004/1
4 years, 8 months ago (2016-04-26 17:08:57 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/288)
4 years, 8 months ago (2016-04-26 17:13:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917883004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917883004/20001
4 years, 8 months ago (2016-04-26 17:47:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 17:49:55 UTC) #9
M-A Ruel
lgtm
4 years, 8 months ago (2016-04-26 18:48:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917883004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917883004/20001
4 years, 7 months ago (2016-04-27 13:14:03 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 13:19:58 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300238

Powered by Google App Engine
This is Rietveld 408576698