Deprecate CheckRietveldTryJobExecution "temporarily fixed" in 2012.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 # Justifications for each filter:
@@ skipping 793 matching lines @@
 
 def RunPylint(input_api, *args, **kwargs):
   """Legacy presubmit function.
 
   For better performance, get all tests and then pass to
   input_api.RunTests.
   """
   return input_api.RunTests(GetPylint(input_api, *args, **kwargs), False)
 
 
-# TODO(dpranke): Get the host_url from the input_api instead
-def CheckRietveldTryJobExecution(dummy_input_api, dummy_output_api,
+def CheckRietveldTryJobExecution(dummy_input_api, output_api,
                                  dummy_host_url, dummy_platforms,
                                  dummy_owner):
-  # Temporarily 'fix' the check while the Rietveld API is being upgraded to
-  # something sensible.
-  return []
+  return [
+    output_api.PresubmitNotifyResult(
+        'CheckRietveldTryJobExecution is deprecated, please remove it.')
+  ]
 
 
 def CheckBuildbotPendingBuilds(input_api, output_api, url, max_pendings,
     ignored):
   try:
     connection = input_api.urllib2.urlopen(url)
     raw_data = connection.read()
     connection.close()
   except IOError:
     return [output_api.PresubmitNotifyResult('%s is not accessible' % url)]
@@ skipping 296 matching lines @@
   for f in affected_files:
     cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]
     rc = gn.main(cmd)
     if rc == 2:
       warnings.append(output_api.PresubmitPromptWarning(
           '%s requires formatting. Please run `gn format --in-place %s`.' % (
               f.AbsoluteLocalPath(), f.LocalPath())))
   # It's just a warning, so ignore other types of failures assuming they'll be
   # caught elsewhere.
   return warnings