Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: presubmit_canned_checks.py

Issue 1917883004: Deprecate CheckRietveldTryJobExecution "temporarily fixed" in 2012. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: thanks, pylint! Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 96bd094c226a8ea0156a0e3b4a240105050e07f9..56d2714fd99204e7468a5a62779b33390b1d8130 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -811,13 +811,13 @@ def RunPylint(input_api, *args, **kwargs):
return input_api.RunTests(GetPylint(input_api, *args, **kwargs), False)
-# TODO(dpranke): Get the host_url from the input_api instead
-def CheckRietveldTryJobExecution(dummy_input_api, dummy_output_api,
+def CheckRietveldTryJobExecution(dummy_input_api, output_api,
dummy_host_url, dummy_platforms,
dummy_owner):
- # Temporarily 'fix' the check while the Rietveld API is being upgraded to
- # something sensible.
- return []
+ return [
+ output_api.PresubmitNotifyResult(
+ 'CheckRietveldTryJobExecution is deprecated, please remove it.')
+ ]
def CheckBuildbotPendingBuilds(input_api, output_api, url, max_pendings,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698