Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 1916713005: [Mac/GN] Allow the info_plist template caller to specify the plist format. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-split-rules
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Allow the info_plist template caller to specify the plist format. Mac expects plists to be in xml1 format, whereas iOS uses binary1. BUG=297668 R=sdefresne@chromium.org Committed: https://crrev.com/548bde205f95f0dd96d7c74db09839e3311ddfd9 Cr-Commit-Position: refs/heads/master@{#390270}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M build/config/ios/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/mac/base_rules.gni View 3 chunks +7 lines, -0 lines 0 comments Download
M build/config/mac/gen_plist.py View 3 chunks +6 lines, -4 lines 0 comments Download
M build/config/mac/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
Robert Sesek
4 years, 8 months ago (2016-04-26 15:26:39 UTC) #1
sdefresne
lgtm
4 years, 7 months ago (2016-04-27 13:02:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916713005/1
4 years, 7 months ago (2016-04-27 17:03:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/174111)
4 years, 7 months ago (2016-04-27 17:12:57 UTC) #6
Robert Sesek
+dpranke for //build/toolchain OWNERS
4 years, 7 months ago (2016-04-27 17:17:28 UTC) #8
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-28 00:48:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916713005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916713005/20001
4 years, 7 months ago (2016-04-28 01:17:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 01:23:15 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/548bde205f95f0dd96d7c74db09839e3311ddfd9
Cr-Commit-Position: refs/heads/master@{#390270}

Powered by Google App Engine
This is Rietveld 408576698