Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918263002: [iOS/Mac/GN] Split out common iOS and Mac rules into base_rules.gni. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/Mac/GN] Split out common iOS and Mac rules into base_rules.gni. BUG=297668 R=sdefresne@chromium.org Committed: https://crrev.com/1c04e6e0f61a134eaf25ac08945f5d683a4e0296 Cr-Commit-Position: refs/heads/master@{#390108}

Patch Set 1 #

Patch Set 2 : Do'h, SDK path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -616 lines) Patch
M build/config/ios/rules.gni View 2 chunks +17 lines, -3 lines 0 comments Download
A + build/config/mac/base_rules.gni View 1 4 chunks +9 lines, -308 lines 0 comments Download
M build/config/mac/rules.gni View 3 chunks +2 lines, -305 lines 0 comments Download

Dependent Patchsets:

Issue 1916713005 Patch 20001

Messages

Total messages: 12 (5 generated)
Robert Sesek
4 years, 8 months ago (2016-04-26 15:13:25 UTC) #1
sdefresne
lgtm
4 years, 7 months ago (2016-04-27 13:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918263002/1
4 years, 7 months ago (2016-04-27 15:26:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/25951)
4 years, 7 months ago (2016-04-27 15:35:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918263002/20001
4 years, 7 months ago (2016-04-27 15:40:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 16:58:35 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:10:45 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c04e6e0f61a134eaf25ac08945f5d683a4e0296
Cr-Commit-Position: refs/heads/master@{#390108}

Powered by Google App Engine
This is Rietveld 408576698