Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6464)

Unified Diff: build/config/mac/base_rules.gni

Issue 1916713005: [Mac/GN] Allow the info_plist template caller to specify the plist format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-split-rules
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | build/config/mac/gen_plist.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/base_rules.gni
diff --git a/build/config/mac/base_rules.gni b/build/config/mac/base_rules.gni
index ae95f4d25d018f246b0187bd79487f8d73e4246d..a1723fe609d19a05b9667b3126631dac836a004b 100644
--- a/build/config/mac/base_rules.gni
+++ b/build/config/mac/base_rules.gni
@@ -24,6 +24,10 @@ if (is_mac) {
# string, name of the generated target used for the product
# and executable name as specified in the output Info.plist.
#
+# format:
+# string, the format to `plutil -convert` the plist to when
+# generating the output.
+#
# extra_substitutions:
# (optional) string array, 'key=value' pairs for extra fields which are
# specified in a source Info.plist template.
@@ -32,6 +36,8 @@ template("info_plist") {
"A list of template plist files must be specified for $target_name")
assert(defined(invoker.executable_name),
"The executable_name must be specified for $target_name")
+ assert(defined(invoker.format),
+ "The plist format must be specified for $target_name")
executable_name = invoker.executable_name
action(target_name) {
@@ -55,6 +61,7 @@ template("info_plist") {
"-s=XCODE_BUILD=$xcode_build",
"-s=XCODE_VERSION=$xcode_version",
"-o=" + rebase_path(outputs[0], root_build_dir),
+ "-f=" + invoker.format,
] + rebase_path(sources, root_build_dir)
args = [ "@{{response_file_name}}" ]
}
« no previous file with comments | « build/config/ios/rules.gni ('k') | build/config/mac/gen_plist.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698