Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 1916503002: Reland of Generate Android .isolate files used for test()s (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org, bengr, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Generate Android .isolate files used for test()s Contains fix for ui_base_tests not having data set correctly for android. TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,apacible@chromium.org NOTRY=true BUG=589318 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e41ae190dadf81f1561c8cdfd8b308b213817210 Cr-Commit-Position: refs/heads/master@{#389470}

Patch Set 1 #

Patch Set 2 : add data for ui/base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -13 lines) Patch
M android_webview/test/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/utils/isolator.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 1 chunk +5 lines, -3 lines 0 comments Download
A testing/generate_isolate.py View 1 chunk +114 lines, -0 lines 0 comments Download
M testing/test.gni View 1 6 chunks +105 lines, -5 lines 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
agrieve
Created Reland of Generate Android .isolate files used for test()s
4 years, 8 months ago (2016-04-22 18:36:13 UTC) #1
agrieve
On 2016/04/22 18:36:13, agrieve wrote: > Created Reland of Generate Android .isolate files used for ...
4 years, 8 months ago (2016-04-22 18:39:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916503002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916503002/190001
4 years, 8 months ago (2016-04-25 14:08:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:190001)
4 years, 8 months ago (2016-04-25 14:13:04 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:14:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e41ae190dadf81f1561c8cdfd8b308b213817210
Cr-Commit-Position: refs/heads/master@{#389470}

Powered by Google App Engine
This is Rietveld 408576698