🐺 Fix net_unittests on Android swarming by adding testserver as a data_dep

Fix net_unittests on Android swarming by adding testserver as a data_dep

TBR=phajdan.jr
BUG=589318
Committed: https://crrev.com/732db3a1bf9a8ef6a0f6263e84c706fd7cdadd08
Cr-Commit-Position: refs/heads/master@{#389844}

[agrieve, 2016-04-26 00:57:40]

agrieve@chromium.org changed reviewers:
+ davidben@chromium.org, phajdan.jr@chromium.org

[davidben, 2016-04-26 16:23:01]

https://codereview.chromium.org/1914073002/diff/1/net/tools/testserver/testse...
File net/tools/testserver/testserver.pydeps (right):

https://codereview.chromium.org/1914073002/diff/1/net/tools/testserver/testse...
net/tools/testserver/testserver.pydeps:2: #   build/print_python_deps.py --root
net/tools/testserver --output net/tools/testserver/testserver.pydeps
net/tools/testserver/testserver.py
Is there any mechanism in place to make sure this file doesn't get out-of-date?

[davidben, 2016-04-26 16:25:58]

lgtm

https://codereview.chromium.org/1914073002/diff/1/net/tools/testserver/testse...
File net/tools/testserver/testserver.pydeps (right):

https://codereview.chromium.org/1914073002/diff/1/net/tools/testserver/testse...
net/tools/testserver/testserver.pydeps:2: #   build/print_python_deps.py --root
net/tools/testserver --output net/tools/testserver/testserver.pydeps
net/tools/testserver/testserver.py
On 2016/04/26 16:23:00, davidben wrote:
> Is there any mechanism in place to make sure this file doesn't get
out-of-date?

Oh, I see. That's what the PRESUBMIT.py change is for.

[agrieve, 2016-04-26 17:01:04]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 17:01:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914073002/1

[commit-bot: I haz the power, 2016-04-26 17:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 17:53:46]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-04-26 19:11:34]

Description was changed from

==========
Fix net_unittests on Android swarming by adding testserver as a data_dep

BUG=589318
==========

to

==========
Fix net_unittests on Android swarming by adding testserver as a data_dep

TBR=phajdan.jr
BUG=589318
==========

[agrieve, 2016-04-26 19:12:10]

On 2016/04/26 17:53:46, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

tbr for the trivial PRESUBMIT.py change

[agrieve, 2016-04-26 19:12:19]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-26 19:12:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914073002/1

[commit-bot: I haz the power, 2016-04-26 19:18:27]

Description was changed from

==========
Fix net_unittests on Android swarming by adding testserver as a data_dep

TBR=phajdan.jr
BUG=589318
==========

to

==========
Fix net_unittests on Android swarming by adding testserver as a data_dep

TBR=phajdan.jr
BUG=589318
==========

[commit-bot: I haz the power, 2016-04-26 19:18:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 19:19:30]

Description was changed from

==========
Fix net_unittests on Android swarming by adding testserver as a data_dep

TBR=phajdan.jr
BUG=589318
==========

to

==========
Fix net_unittests on Android swarming by adding testserver as a data_dep

TBR=phajdan.jr
BUG=589318

Committed: https://crrev.com/732db3a1bf9a8ef6a0f6263e84c706fd7cdadd08
Cr-Commit-Position: refs/heads/master@{#389844}
==========

[commit-bot: I haz the power, 2016-04-26 19:19:31]

Patchset 1 (id:??) landed as
https://crrev.com/732db3a1bf9a8ef6a0f6263e84c706fd7cdadd08
Cr-Commit-Position: refs/heads/master@{#389844}