Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1922023002: 🐻 Fix ui_base_unittests on Android Swarming (adds missing data) (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
jbudorick, sadrul
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gen-isolates-android
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ui_base_unittests on Android Swarming (adds missing data) BUG=589318 Committed: https://crrev.com/f9917d1e7bc35236ad1e49f888f608c11d563ecf Cr-Commit-Position: refs/heads/master@{#389845}

Patch Set 1 #

Total comments: 4

Patch Set 2 : @classmethod #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M build/android/pylib/utils/isolator.py View 1 2 chunks +12 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
agrieve
4 years, 8 months ago (2016-04-26 01:39:38 UTC) #2
jbudorick
lgtm w/ nits https://codereview.chromium.org/1922023002/diff/1/build/android/pylib/utils/isolator.py File build/android/pylib/utils/isolator.py (right): https://codereview.chromium.org/1922023002/diff/1/build/android/pylib/utils/isolator.py#newcode155 build/android/pylib/utils/isolator.py:155: @staticmethod nit: @classmethod https://codereview.chromium.org/1922023002/diff/1/build/android/pylib/utils/isolator.py#newcode159 build/android/pylib/utils/isolator.py:159: Isolator._DestructiveMerge(os.path.join(src, ...
4 years, 8 months ago (2016-04-26 15:51:49 UTC) #3
sadrul
stamp lgtm
4 years, 8 months ago (2016-04-26 16:26:51 UTC) #4
agrieve
https://codereview.chromium.org/1922023002/diff/1/build/android/pylib/utils/isolator.py File build/android/pylib/utils/isolator.py (right): https://codereview.chromium.org/1922023002/diff/1/build/android/pylib/utils/isolator.py#newcode155 build/android/pylib/utils/isolator.py:155: @staticmethod On 2016/04/26 15:51:49, jbudorick wrote: > nit: @classmethod ...
4 years, 8 months ago (2016-04-26 17:34:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922023002/20001
4 years, 8 months ago (2016-04-26 17:34:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 19:20:31 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:22:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9917d1e7bc35236ad1e49f888f608c11d563ecf
Cr-Commit-Position: refs/heads/master@{#389845}

Powered by Google App Engine
This is Rietveld 408576698