Issue 191643002: Revert 255621 "Telemetry support for iframes."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 191643002: Revert 255621 "Telemetry support for iframes." (Closed)

Created:
6 years, 9 months ago by xhwang

Modified:
6 years, 9 months ago

Reviewers:
achuithb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 255621 "Telemetry support for iframes." > Telemetry support for iframes. > > * Add methods EvaluateJavaScriptInContext, > ExecuteJavaScriptInContext. > * Backend classes take an additional context_id argument, which refers to the iframe. > * WebContents has an EnableAllContexts method, to enable access to iframes. > * Add tests testIFrame, and unit test data files host.html, iframe*.html. > > BUG=237032 > TEST=unittest > > Review URL: https://codereview.chromium.org/183863007 BUG=350568 TBR=achuith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255715

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -110 lines)			Patch
M	trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py	View	4 chunks	+18 lines, -14 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/web_contents.py	View	2 chunks	+2 lines, -20 lines	0 comments	Download
D	trunk/src/tools/telemetry/unittest_data/host.html	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	trunk/src/tools/telemetry/unittest_data/iframe1.html	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	trunk/src/tools/telemetry/unittest_data/iframe2.html	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	trunk/src/tools/telemetry/unittest_data/iframe3.html	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r255715.

Expand Messages | Collapse Messages