Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py

Issue 191643002: Revert 255621 "Telemetry support for iframes." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py (revision 255714)
+++ trunk/src/tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py (working copy)
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from telemetry.core import exceptions
-from telemetry.core import util
from telemetry.unittest import tab_test_case
class InspectorRuntimeTest(tab_test_case.TabTestCase):
@@ -30,28 +29,3 @@
def testRuntimeExecuteOfSomethingThatCantJSONize(self):
self._tab.ExecuteJavaScript('window')
-
- def testIFrame(self):
- self._browser.SetHTTPServerDirectories(util.GetUnittestDataDir())
- self._tab.Navigate(self._browser.http_server.UrlOf('host.html'))
-
- # Access host page.
- self._tab.WaitForJavaScriptExpression(
- "typeof(testVar) != 'undefined'", timeout=5)
- self.assertEquals(self._tab.EvaluateJavaScript('testVar'), 'host')
-
- # Access parent page using EvaluateJavaScriptInContext.
- self.assertEquals(self._tab.EvaluateJavaScriptInContext('testVar',
- context_id=1), 'host')
-
- # Access the iframes.
- self.assertEquals(self._tab.EvaluateJavaScriptInContext('testVar',
- context_id=2), 'iframe1')
- self.assertEquals(self._tab.EvaluateJavaScriptInContext('testVar',
- context_id=3), 'iframe2')
- self.assertEquals(self._tab.EvaluateJavaScriptInContext('testVar',
- context_id=4), 'iframe3')
-
- # Accessing a non-existent iframe throws an exception.
- self.assertRaises(exceptions.EvaluateException,
- lambda: self._tab.EvaluateJavaScriptInContext('1+1', context_id=5))

Powered by Google App Engine
This is Rietveld 408576698