Telemetry support for iframes.

Telemetry support for iframes.

* Add methods EvaluateJavaScriptInContext,
ExecuteJavaScriptInContext.
* Backend classes take an additional context_id argument, which refers to the iframe.
* WebContents has an EnableAllContexts method, to enable access to iframes.
* Add tests testIFrame, and unit test data files host.html, iframe*.html.

BUG=237032, 350568
TEST=unittest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255621

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256611

[achuithb, 2014-02-28 03:45:09]

Tony, here's a first cut.

I didn't want to change the signature of EvaluateJavaScript, ExecuteJavaScript,
WaitForJavaScript, so I added additional methods EvaluateJavaScriptInContext,
etc. The alternative was to have context_id be the last argument, after timeout.
There are a lot of callsites that do something like EvaluateJavaScript('1+1',
60), so I think timeout has to be the third argument. 

Let me know what you think.

[tonyg, 2014-03-05 03:10:00]

Everything else lg

https://codereview.chromium.org/183863007/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_page.py (right):

https://codereview.chromium.org/183863007/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:38: 'method':
'Runtime.enable'})
Is there any way this could be more lazy? I'm concerned about its possible
performance impacts in the common case.

[achuithb, 2014-03-06 05:45:41]

I've added a method EnableAllContexts to WebContents, so access to iframes must
be explicitly requested.

PTAL, Tony.

https://codereview.chromium.org/183863007/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_page.py (right):

https://codereview.chromium.org/183863007/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:38: 'method':
'Runtime.enable'})
On 2014/03/05 03:10:00, tonyg wrote:
> Is there any way this could be more lazy? I'm concerned about its possible
> performance impacts in the common case.

Done.

[tonyg, 2014-03-06 14:53:08]

Please address the last comment before landing.

lgtm

https://codereview.chromium.org/183863007/diff/100001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/web_contents.py (right):

https://codereview.chromium.org/183863007/diff/100001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/web_contents.py:109: def EnableAllContexts(self):
To make this API smaller and easier to use, let's make this method private and
call it the first time one of the *InContext methods is called.

[achuithb, 2014-03-06 19:43:51]

Please excuse the rebase.

Please take another look, I've moved EnableAllContexts to InspectorRuntime and
made it private.

https://codereview.chromium.org/183863007/diff/100001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/web_contents.py (right):

https://codereview.chromium.org/183863007/diff/100001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/web_contents.py:109: def EnableAllContexts(self):
On 2014/03/06 14:53:09, tonyg wrote:
> To make this API smaller and easier to use, let's make this method private and
> call it the first time one of the *InContext methods is called.

Done.

[achuithb, 2014-03-07 11:57:20]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-03-07 11:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/183863007/120001

[commit-bot: I haz the power, 2014-03-07 15:33:50]

Change committed as 255621

[achuithb, 2014-03-12 00:17:40]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2014-03-12 00:17:48]

The CQ bit was unchecked by achuith@chromium.org

[achuithb, 2014-03-12 00:18:10]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-03-12 00:20:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/183863007/140001

[commit-bot: I haz the power, 2014-03-12 05:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 05:11:42]

Try jobs failed on following builders: linux_chromium_rel

[achuithb, 2014-03-12 08:20:06]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-03-12 08:27:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/183863007/170001

[commit-bot: I haz the power, 2014-03-12 10:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 10:24:54]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[achuithb, 2014-03-12 10:40:58]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-03-12 10:41:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/183863007/170001

[commit-bot: I haz the power, 2014-03-12 16:53:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/183863007/170001

[commit-bot: I haz the power, 2014-03-12 19:13:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/183863007/170001

[commit-bot: I haz the power, 2014-03-12 19:53:08]

Change committed as 256611