Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916283003: [K6] Replace bind() + GCed pointers with retainedRef() (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, tzik, dshwang, eae+blinkwatch, eric.carlson_apple.com, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, philipj_slow, Mads Ager (chromium), Peter Beverloo, sof, mlamouri+watch-blink_chromium.org, nhiroki, Raymond Toy, loading-reviews_chromium.org, tommyw+watchlist_chromium.org, lushnikov+blink_chromium.org, haraken, loading-reviews+fetch_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, feature-media-reviews_chromium.org, ajuma+watch-canvas_chromium.org, falken, pfeldman+blink_chromium.org, mcasas+watch+mediastream_chromium.org, oilpan-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, kouhei+heap_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_5c
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace bind() + GCed pointers with retainedRef() BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -179 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/BeaconLoader.cpp View 1 2 3 chunks +107 lines, -100 lines 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageErrorCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 2 15 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (2 generated)
hiroshige
Description was changed from ========== Replace GCed raw pointers with retainedRef() BUG= ========== to ========== ...
4 years, 8 months ago (2016-04-26 11:40:05 UTC) #1
hiroshige
4 years, 8 months ago (2016-04-26 11:46:05 UTC) #2 
Description was changed from

==========
Replace GCed raw pointers with retainedRef()

BUG=
==========

to

==========
Replace bind() + GCed pointers with retainedRef()

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698