third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 1916283003: [K6] Replace bind() + GCed pointers with retainedRef()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 1916283003: [K6] Replace bind() + GCed pointers with retainedRef() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_5c

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | third_party/WebKit/Source/modules/quota/StorageErrorCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index a874cbe0ba0267b670cf4caeeafb4d89d670ea9b..15fdc5272462d452ce9d21217c72a023ba0d98ee 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -173,7 +173,7 @@ void Notification::close()

if (m_persistentId == kInvalidPersistentId) {

// Fire the close event asynchronously.

- getExecutionContext()->postTask(BLINK_FROM_HERE, createSameThreadTask(&Notification::dispatchCloseEvent, this));

+ getExecutionContext()->postTask(BLINK_FROM_HERE, createSameThreadTask(&Notification::dispatchCloseEvent, retainedRef(this)));

m_state = NotificationStateClosing;

notificationManager()->close(this);