third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp - Issue 1916283003: [K6] Replace bind() + GCed pointers with retainedRef()

Unified Diff: third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp

Issue 1916283003: [K6] Replace bind() + GCed pointers with retainedRef() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_5c

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp b/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp

index 82cc46da21c882a1791aa21bb4335f6691bf5525..29e1b55bd4b8dc413b68a04ffe3eac08e9d6a9b7 100644

--- a/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp

@@ -86,8 +86,8 @@ void LocalFileSystem::resolveURL(ExecutionContext* context, const KURL& fileSyst

ExecutionContext* contextPtr(context);

CallbackWrapper* wrapper = new CallbackWrapper(std::move(callbacks));

requestFileSystemAccessInternal(context,

- bind(&LocalFileSystem::resolveURLInternal, this, contextPtr, fileSystemURL, wrapper),

- bind(&LocalFileSystem::fileSystemNotAllowedInternal, this, contextPtr, wrapper));

+ bind(&LocalFileSystem::resolveURLInternal, retainedRef(this), retainedRef(contextPtr), fileSystemURL, retainedRef(wrapper)),

+ bind(&LocalFileSystem::fileSystemNotAllowedInternal, retainedRef(this), retainedRef(contextPtr), retainedRef(wrapper)));

}

void LocalFileSystem::requestFileSystem(ExecutionContext* context, FileSystemType type, long long size, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

@@ -95,8 +95,8 @@ void LocalFileSystem::requestFileSystem(ExecutionContext* context, FileSystemTyp

ExecutionContext* contextPtr(context);

CallbackWrapper* wrapper = new CallbackWrapper(std::move(callbacks));

requestFileSystemAccessInternal(context,

- bind(&LocalFileSystem::fileSystemAllowedInternal, this, contextPtr, type, wrapper),

- bind(&LocalFileSystem::fileSystemNotAllowedInternal, this, contextPtr, wrapper));

+ bind(&LocalFileSystem::fileSystemAllowedInternal, retainedRef(this), retainedRef(contextPtr), type, retainedRef(wrapper)),

+ bind(&LocalFileSystem::fileSystemNotAllowedInternal, retainedRef(this), retainedRef(contextPtr), retainedRef(wrapper)));

}

void LocalFileSystem::deleteFileSystem(ExecutionContext* context, FileSystemType type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

@@ -107,8 +107,8 @@ void LocalFileSystem::deleteFileSystem(ExecutionContext* context, FileSystemType

CallbackWrapper* wrapper = new CallbackWrapper(std::move(callbacks));

requestFileSystemAccessInternal(context,

- bind(&LocalFileSystem::deleteFileSystemInternal, this, contextPtr, type, wrapper),

- bind(&LocalFileSystem::fileSystemNotAllowedInternal, this, contextPtr, wrapper));

+ bind(&LocalFileSystem::deleteFileSystemInternal, retainedRef(this), retainedRef(contextPtr), type, retainedRef(wrapper)),

+ bind(&LocalFileSystem::fileSystemNotAllowedInternal, retainedRef(this), retainedRef(contextPtr), retainedRef(wrapper)));

}

WebFileSystem* LocalFileSystem::fileSystem() const