Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916263003: Reland "Skia: Maintain a checkout on swarming (compile) bots" (Closed)

Created:
4 years, 8 months ago by borenet2
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland "Skia: Maintain a checkout on swarming (compile) bots" TBR=phajdan.jr@chromium.org BUG=skia:5213 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300234

Patch Set 1 : revert the revert #

Patch Set 2 : Fixes for Windows, CMake #

Patch Set 3 : rebase #

Patch Set 4 : Fix expectations after roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1027 lines, -181 lines) Patch
M scripts/slave/isolation/recipes.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/skia/api.py View 1 7 chunks +56 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/skia/chromeos_flavor.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/skia/cmake_flavor.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipe_modules/skia/default_flavor.py View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/skia/xsan_flavor.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/skia_swarming/api.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/housekeeper_percommit.py View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/housekeeper_percommit.expected/Housekeeper-PerCommit.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/housekeeper_percommit.expected/Housekeeper-PerCommit-Trybot.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.py View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Mac10.8-Clang-Arm7-Debug-Android.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Mac10.9-Clang-Arm7-Debug-iOS.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-Android.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-x86_64-Release-CMake.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Win-MSVC-x86-Debug-VS2015.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Housekeeper-PerCommit.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Housekeeper-PerCommit-Trybot.json View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Appurify.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Release-Appurify.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Link-CPU-AVX-x86_64-Debug.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/download_and_push_skimage.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/download_and_push_skps.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_dm.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_get_hashes.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/has_ccache_android.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SK_IMAGE_VERSION_device.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SK_IMAGE_VERSION_host.json View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-Arm7-Release-iOS.json View 1 2 3 4 chunks +81 lines, -7 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Mac-Clang-x86_64-Release-CMake.json View 1 2 3 3 chunks +81 lines, -7 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot.json View 1 2 3 5 chunks +123 lines, -11 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-Arm7-Release-Android.json View 1 2 3 5 chunks +87 lines, -11 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link.json View 1 2 3 3 chunks +81 lines, -7 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-CMake.json View 1 2 3 3 chunks +81 lines, -7 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-Valgrind.json View 1 2 3 3 chunks +81 lines, -7 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_compile.expected/Build-Win-MSVC-x86-Debug-VS2015.json View 1 2 3 4 chunks +82 lines, -8 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 2 3 23 chunks +46 lines, -23 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Release.json View 1 2 3 20 chunks +40 lines, -20 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Mac-Clang-x86_64-Release-Swarming.json View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Debug-Swarming.json View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Release-Swarming-Trybot.json View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/No_downloaded_SKP_VERSION.json View 1 2 3 6 chunks +9 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming-Trybot.json View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release-Swarming.json View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-ChromeOS-GCC-Link-CPU-AVX-x86_64-Debug.json View 1 2 3 6 chunks +9 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Swarming.json View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Swarming.json View 1 2 3 6 chunks +9 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 6 chunks +9 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Swarming.json View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Swarming.json View 1 2 3 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
borenet
Patch set 1 relands the original patch. Patch set 2 contains fixes for CMake and ...
4 years, 8 months ago (2016-04-26 14:58:29 UTC) #2
rmistry1
lgtm
4 years, 8 months ago (2016-04-26 14:59:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916263003/40001
4 years, 7 months ago (2016-04-27 11:11:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4393)
4 years, 7 months ago (2016-04-27 11:18:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916263003/40001
4 years, 7 months ago (2016-04-27 11:20:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4398)
4 years, 7 months ago (2016-04-27 11:27:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916263003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916263003/60001
4 years, 7 months ago (2016-04-27 11:32:37 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 11:36:48 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300234

Powered by Google App Engine
This is Rietveld 408576698