scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json - Issue 1916263003: Reland "Skia: Maintain a checkout on swarming (compile) bots"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json

Issue 1916263003: Reland "Skia: Maintain a checkout on swarming (compile) bots" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Fix expectations after roll Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Release-Swarming-Trybot.json ('k') | scripts/slave/recipes/skia/swarm_trigger.expected/No_downloaded_SKP_VERSION.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json

diff --git a/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json b/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json

index 3e0ac8440d19b04263988b75474889a8af4d570b..7e7902cb3885b0662cba8ac65fc6897d54c4dd87 100644

--- a/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json

+++ b/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win8-MSVC-x86_64-Release-Swarming.json

@@ -430,7 +430,7 @@

"cmd": [

"python",

"-u",

- "\nimport json\nimport sys\nwith open(sys.argv[1]) as f:\n isolated = json.load(f)\nfor h in sys.argv[2:]:\n isolated['includes'].append(h)\nwith open(sys.argv[1], 'w') as f:\n json.dump(isolated, f, sort_keys=True)\n",

+ "\nimport json\nimport sys\nwith open(sys.argv[1]) as f:\n isolated = json.load(f)\nif not isolated.get('includes'):\n isolated['includes'] = []\nfor h in sys.argv[2:]:\n isolated['includes'].append(h)\nwith open(sys.argv[1], 'w') as f:\n json.dump(isolated, f, sort_keys=True)\n",

"[SLAVE_BUILD]/swarming_temp_dir/skia-task-compile_skia.isolated",

"[dummy hash for isolate_recipes]",

"705384d88f80da637eb367e5acc6f315c0e1db2f"

@@ -442,6 +442,8 @@

"@@@STEP_LOG_LINE@python.inline@import sys@@@",

"@@@STEP_LOG_LINE@python.inline@with open(sys.argv[1]) as f:@@@",

"@@@STEP_LOG_LINE@python.inline@ isolated = json.load(f)@@@",

+ "@@@STEP_LOG_LINE@python.inline@if not isolated.get('includes'):@@@",

+ "@@@STEP_LOG_LINE@python.inline@ isolated['includes'] = []@@@",

"@@@STEP_LOG_LINE@python.inline@for h in sys.argv[2:]:@@@",

"@@@STEP_LOG_LINE@python.inline@ isolated['includes'].append(h)@@@",

"@@@STEP_LOG_LINE@python.inline@with open(sys.argv[1], 'w') as f:@@@",