scripts/slave/recipe_modules/skia/cmake_flavor.py - Issue 1916263003: Reland "Skia: Maintain a checkout on swarming (compile) bots"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/skia/cmake_flavor.py

Issue 1916263003: Reland "Skia: Maintain a checkout on swarming (compile) bots" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Fix expectations after roll Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/skia/cmake_flavor.py

diff --git a/scripts/slave/recipe_modules/skia/cmake_flavor.py b/scripts/slave/recipe_modules/skia/cmake_flavor.py

index 8a6166767f60b590090f790c8dcd5461a9f79f75..c88d3694512a0d105794ac4a5579baa6195e6173 100644

--- a/scripts/slave/recipe_modules/skia/cmake_flavor.py

+++ b/scripts/slave/recipe_modules/skia/cmake_flavor.py

@@ -9,7 +9,6 @@ import default_flavor

class CMakeFlavorUtils(default_flavor.DefaultFlavorUtils):

def compile(self, target):

"""Build Skia with CMake. Ignores `target`."""

- cmake_build = self._skia_api.m.path['slave_build'].join(

- 'skia', 'cmake', 'cmake_build')

+ cmake_build = self._skia_api.skia_dir.join('cmake', 'cmake_build')

self._skia_api.run(self._skia_api.m.step, 'cmake_build', cmd=[cmake_build],

cwd=self._skia_api.m.path['checkout'])

« no previous file with comments | « scripts/slave/recipe_modules/skia/chromeos_flavor.py ('k') | scripts/slave/recipe_modules/skia/default_flavor.py » ('j') | no next file with comments »