Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated.

Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated.

I.e., rename them to ConnectTo{Application,Service}Deprecated() (which
will at least be easier/more reliable to grep for).

* ApplicationImpl::ConnectToService() can/should nearly always be
  replaced with a use of mojo::ConnectToService() from connect.h. (The
  ApplicationImpl::ConnectToService() is unusually inefficient for what
  it's used for.)
* ApplicationImpl::ConnectToApplication() is used by
  ApplicationImpl::ConnectToService() (accounting for the latter's gross
  inefficiency), and sometimes semi-legitimately to connect to *and*
  provide services to, e.g., the tracing service. It has the side-effect
  of keeping connections alive, but maybe that should just be done
  "manually" instead; such uses can be replaced with
  shell()->ConnectToApplication() (and manual lifetime management), or
  maybe by making mojo::ConnectToService() slightly more general. (There
  are also a few dubious-looking uses, to be investigated.)

For now, I've just renamed them. I plan to fix the actual call sites (in
the ways indicated above) more incrementally.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/7c97b4f370e3a86f1a5eef522c829f20cf25eca7

[viettrungluu, 2016-04-25 21:48:35]

Despite the apparent size of this change, it's actually very trivial (i.e., just
a rename of a couple of methods).

[vardhan, 2016-04-25 23:29:30]

lgtm

[viettrungluu, 2016-04-25 23:55:31]

Description was changed from

==========
Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated.

I.e., rename them to ConnectTo{Application,Service}Deprecated() (which
will at least be easier/more reliable to grep for).

* ApplicationImpl::ConnectToService() can/should nearly always be
  replaced with a use of mojo::ConnectToService() from connect.h. (The
  ApplicationImpl::ConnectToService() is unusually inefficient for what
  it's used for.)
* ApplicationImpl::ConnectToApplication() is used by
  ApplicationImpl::ConnectToService() (accounting for the latter's gross
  inefficiency), and sometimes semi-legitimately to connect to *and*
  provide services to, e.g., the tracing service. It has the side-effect
  of keeping connections alive, but maybe that should just be done
  "manually" instead; such uses can be replaced with
  shell()->ConnectToApplication() (and manual lifetime management), or
  maybe by making mojo::ConnectToService() slightly more general. (There
  are also a few dubious-looking uses, to be investigated.)

For now, I've just renamed them. I plan to fix the actual call sites (in
the ways indicated above) more incrementally.

R=vardhan@google.com
==========

to

==========
Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated.

I.e., rename them to ConnectTo{Application,Service}Deprecated() (which
will at least be easier/more reliable to grep for).

* ApplicationImpl::ConnectToService() can/should nearly always be
  replaced with a use of mojo::ConnectToService() from connect.h. (The
  ApplicationImpl::ConnectToService() is unusually inefficient for what
  it's used for.)
* ApplicationImpl::ConnectToApplication() is used by
  ApplicationImpl::ConnectToService() (accounting for the latter's gross
  inefficiency), and sometimes semi-legitimately to connect to *and*
  provide services to, e.g., the tracing service. It has the side-effect
  of keeping connections alive, but maybe that should just be done
  "manually" instead; such uses can be replaced with
  shell()->ConnectToApplication() (and manual lifetime management), or
  maybe by making mojo::ConnectToService() slightly more general. (There
  are also a few dubious-looking uses, to be investigated.)

For now, I've just renamed them. I plan to fix the actual call sites (in
the ways indicated above) more incrementally.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/7c97b4f370e3a86f1a5eef522c8...
==========

[viettrungluu, 2016-04-25 23:55:33]

Committed patchset #1 (id:1) manually as
7c97b4f370e3a86f1a5eef522c829f20cf25eca7 (presubmit successful).