services/test_service/test_service_impl.cc - Issue 1916233002: Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/test_service/test_service_impl.cc

Issue 1916233002: Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc ('k') | services/test_service/test_time_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/test_service/test_service_impl.cc

diff --git a/services/test_service/test_service_impl.cc b/services/test_service/test_service_impl.cc

index 9d7d8f81460d591785a81774fcf47a2c9e572028..aa0f4d54911adb0a736b7c94ca7c513d1ae56992 100644

--- a/services/test_service/test_service_impl.cc

+++ b/services/test_service/test_service_impl.cc

@@ -43,7 +43,7 @@ void SendTimeResponse(

void TestServiceImpl::ConnectToAppAndGetTime(

const mojo::String& app_url,

const mojo::Callback<void(int64_t)>& callback) {

- app_impl_->ConnectToService(app_url, &time_service_);

+ app_impl_->ConnectToServiceDeprecated(app_url, &time_service_);

if (tracking_) {

tracking_->RecordNewRequest();

time_service_->StartTrackingRequests(mojo::Callback<void()>());

@@ -54,7 +54,8 @@ void TestServiceImpl::ConnectToAppAndGetTime(

void TestServiceImpl::StartTrackingRequests(

const mojo::Callback<void()>& callback) {

TestRequestTrackerPtr tracker;

- app_impl_->ConnectToService("mojo:test_request_tracker_app", &tracker);

+ app_impl_->ConnectToServiceDeprecated("mojo:test_request_tracker_app",

+ &tracker);

tracking_.reset(new TrackedService(tracker.Pass(), Name_, callback));

}