services/media/factory_service/media_player_impl.cc - Issue 1916233002: Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/factory_service/media_player_impl.cc

Issue 1916233002: Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/media/factory_service/audio_track_controller.cc ('k') | services/media/factory_service/network_reader_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/media/factory_service/media_player_impl.cc

diff --git a/services/media/factory_service/media_player_impl.cc b/services/media/factory_service/media_player_impl.cc

index 49cf9f18dc1cf6b40c1379525db81ea61c87c43d..fde6362a38059f862cf579d4850fe72296780c9b 100644

--- a/services/media/factory_service/media_player_impl.cc

+++ b/services/media/factory_service/media_player_impl.cc

@@ -39,7 +39,7 @@ MediaPlayerImpl::MediaPlayerImpl(InterfaceHandle<SeekingReader> reader,

// Go away when the client is no longer connected.

binding_.set_connection_error_handler([this]() { ReleaseFromOwner(); });

- app()->ConnectToService("mojo:media_factory", &factory_);

+ app()->ConnectToServiceDeprecated("mojo:media_factory", &factory_);

factory_->CreateDemux(reader.Pass(), GetProxy(&demux_));

« no previous file with comments | « services/media/factory_service/audio_track_controller.cc ('k') | services/media/factory_service/network_reader_impl.cc » ('j') | no next file with comments »