Fetch Gerrit cl description from gitiles.

Fetch Gerrit cl description from gitiles.

R=andybons@chromium.org,scottmg@chromium.org
BUG=603207, 605563
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300161

[tandrii(chromium), 2016-04-25 19:08:20]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 19:08:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916123002/1

[commit-bot: I haz the power, 2016-04-25 19:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 19:10:58]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-04-25 19:15:31]

lgtm

https://codereview.chromium.org/1916123002/diff/1/gerrit_util.py
File gerrit_util.py (right):

https://codereview.chromium.org/1916123002/diff/1/gerrit_util.py#newcode487
gerrit_util.py:487: """Query Gitiles for acutal commit message for a given url
and ref.
acutal -> actual

[tandrii(chromium), 2016-04-25 19:19:44]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-04-25 19:19:44]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1916123002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-04-25 19:19:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916123002/20001

[tandrii(chromium), 2016-04-25 19:20:00]

thanks for review

https://codereview.chromium.org/1916123002/diff/1/gerrit_util.py
File gerrit_util.py (right):

https://codereview.chromium.org/1916123002/diff/1/gerrit_util.py#newcode487
gerrit_util.py:487: """Query Gitiles for acutal commit message for a given url
and ref.
On 2016/04/25 19:15:31, scottmg wrote:
> acutal -> actual

Done.

[Bons, 2016-04-25 19:23:01]

lgtm

https://codereview.chromium.org/1916123002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1916123002/diff/1/git_cl.py#newcode2166
git_cl.py:2166: url = data['revisions'][current_rev]['fetch']['http']['url']
While it is true that http is a fetch protocol that’s turned on for the chromium
gerrit instance, it has the possibility of not being available (say if we change
the config). May be worth putting a comment in or handling the error if it’s not
there so that users don’t see an opaque failure.

[commit-bot: I haz the power, 2016-04-25 19:23:28]

Description was changed from

==========
Fetch Gerrit cl description from gitiles.

R=andybons@chromium.org,scottmg@chromium.org
BUG=603207,605563
==========

to

==========
Fetch Gerrit cl description from gitiles.

R=andybons@chromium.org,scottmg@chromium.org
BUG=603207,605563

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300161
==========

[commit-bot: I haz the power, 2016-04-25 19:23:29]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300161

[tandrii(chromium), 2016-04-25 19:27:36]

On 2016/04/25 19:23:01, Bons wrote:
> lgtm
> 
> https://codereview.chromium.org/1916123002/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/1916123002/diff/1/git_cl.py#newcode2166
> git_cl.py:2166: url = data['revisions'][current_rev]['fetch']['http']['url']
> While it is true that http is a fetch protocol that’s turned on for the
chromium
> gerrit instance, it has the possibility of not being available (say if we
change
> the config). May be worth putting a comment in or handling the error if it’s
not
> there so that users don’t see an opaque failure.

Hm, good point. Adding TODO with new CL.

[tandrii(chromium), 2016-04-25 19:31:31]

On 2016/04/25 19:27:36, tandrii(chromium) wrote:
> On 2016/04/25 19:23:01, Bons wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/1916123002/diff/1/git_cl.py
> > File git_cl.py (right):
> > 
> > https://codereview.chromium.org/1916123002/diff/1/git_cl.py#newcode2166
> > git_cl.py:2166: url = data['revisions'][current_rev]['fetch']['http']['url']
> > While it is true that http is a fetch protocol that’s turned on for the
> chromium
> > gerrit instance, it has the possibility of not being available (say if we
> change
> > the config). May be worth putting a comment in or handling the error if it’s
> not
> > there so that users don’t see an opaque failure.
> 
> Hm, good point. Adding TODO with new CL.

https://codereview.chromium.org/1913913002