Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1915153003: Add basic Gerrit support for presubmit_support. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
Bons, scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@P500
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M presubmit_support.py View 4 chunks +30 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1916123002 Patch 20001

Messages

Total messages: 14 (6 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-25 19:08:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915153003/1
4 years, 8 months ago (2016-04-25 19:08:44 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/261)
4 years, 8 months ago (2016-04-25 19:13:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915153003/20001
4 years, 8 months ago (2016-04-25 19:24:03 UTC) #7
Bons
lgtm
4 years, 8 months ago (2016-04-25 19:24:41 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 19:26:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915153003/20001
4 years, 8 months ago (2016-04-25 19:35:07 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 19:37:23 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300164

Powered by Google App Engine
This is Rietveld 408576698